New issue
Advanced search Search tips

Issue 852314 link

Starred by 1 user
Status: Fixed
Owner:
altimin@chromium.org
Closed: Aug 15
Cc:
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 849758



Sign in to add a comment

Detect "dark matter" CPU usage via thread time metrics

Project Member Reported by altimin@chromium.org, Jun 13 2018 
At the moment our thread load metrics are wall-time based and measure only time inside scheduler tasks.

Adding thread-time based will allow us to track the total amount of work and the amount of non-scheduling work (e.g. message loop overhead, system events, scheduling overhead, time observers, etc).

Comment 1 by altimin@chromium.org, Jun 13 2018

Blocking: 849758
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf

commit 1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf
Author: Alexander Timin <altimin@chromium.org>
Date: Fri Jul 13 16:21:40 2018

[scheduler] Add dark matter metrics.

Add
Scheduler.Experimental.Renderer.CPUTimePerThreadType.{Tracked,NonTracked}
histograms to measure and report cpu time not captured by the scheduler.

BUG= 852314 
R=rkaplow@chromium.org,alexclarke@chromium.org
TBR=gab@chromium.org

Change-Id: I4ebdb22fac455ee1887abdc3b739162a970aa900
Reviewed-on: https://chromium-review.googlesource.com/1133258
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574940}
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/base/BUILD.gn
[add] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/base/task/sequence_manager/sequence_manager.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/base/task/sequence_manager/sequence_manager.h
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/base/task/sequence_manager/sequence_manager_impl.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/base/task/sequence_manager/sequence_manager_impl.h
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/common/metrics_helper.h
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/common/metrics_helper_unittest.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.h
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/worker/compositor_metrics_helper.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/worker/compositor_metrics_helper.h
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.h
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/1757cb4e78f3792ea0f2c67e37c1fde6c50b25bf/tools/metrics/histograms/histograms.xml

Comment 3 by altimin@chromium.org, Aug 15

Status: Fixed (was: Assigned)
Scheduler.Experimental.Renderer.CPUTimePerThreadType.{Tracked,NonTracked} are added.
►

Sign in to add a comment