Add a class encompassing the generation element and other data |
|
Issue descriptionThis is to be used in PasswordGenerationAgent and should include the generation element, the form data and other bools relevant to its state. All events that change the state of this new object(e.g. focus changes, text changes) should pass through it and all relevant checks for these events should be performed on the object (e.g. whether generation was manually triggered or automatically triggered, etc.).
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/774332ae986db3ad058a2683790025cce1143992 commit 774332ae986db3ad058a2683790025cce1143992 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Tue Nov 06 14:16:58 2018 Create a separate structure that tracks the current generation status for a field in PasswordGenerationAgent. Currently |generation_element_| has a double meaning. It's an element that should trigger the automatic generation. However, if a manual generation is triggered then it's overwritten by a password field. That's confusing. The CL decouples the field that should trigger the automatic generation from whatever is happening right now on a random password field. In the future that will allow us to have multiple generation elements simultaneously. For now it fixes 870220 where the manual generation on the ambiguous field was suppressing the automatic generation on it. Bug: 870220 ,852309 Change-Id: I6a3edd351e615289f6271fda5a45f6ff47e653af Reviewed-on: https://chromium-review.googlesource.com/c/1310713 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#605668} [modify] https://crrev.com/774332ae986db3ad058a2683790025cce1143992/chrome/browser/password_manager/password_generation_interactive_uitest.cc [modify] https://crrev.com/774332ae986db3ad058a2683790025cce1143992/chrome/renderer/autofill/password_generation_agent_browsertest.cc [modify] https://crrev.com/774332ae986db3ad058a2683790025cce1143992/components/autofill/content/renderer/password_generation_agent.cc [modify] https://crrev.com/774332ae986db3ad058a2683790025cce1143992/components/autofill/content/renderer/password_generation_agent.h |
|
►
Sign in to add a comment |
|
Comment 1 by ioanap@chromium.org
, Jul 20