New issue
Advanced search Search tips

Issue 852284 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Show the serial number on a disable device screen

Project Member Reported by igorcov@chromium.org, Jun 13 2018

Issue description

Currently it happens for device to have different serial number than the sticker. Or the sticker might become unreadable. To help users and developers investigate when the device is disabled by mistake, we need to have an easy access to serial number used by the device.
 

Comment 1 by bchu...@lodiusd.org, Jun 13 2018

When a device is disabled and contains a serial number internally that does not match the serial number sticker there is no way to obtain the serial number of that device.  This can occur when repairs are made and the internal serial isn't changed, and also is an issue if the label is removed.  Please add the serial number and asset number to the disabled screen to aid in re-enabling the correct device.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d6721f24a5e330bb14212bf953f6e28b0c59fa2

commit 7d6721f24a5e330bb14212bf953f6e28b0c59fa2
Author: Igor <igorcov@chromium.org>
Date: Thu Jun 21 11:15:59 2018

Display serial_number for disabled device

If the device is disabled, it can be brought back to life only by the
admin of the domain. And to re-enable the device, admin needs the serial
number which might not match the data displayed on the sticker. Or the
sticker could be damaged. This change will provide the serial number on
the disabled device screen.

BUG= chromium:852284 
TEST=Unit tests

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3fe38afc59d7c08ffc175c723b1a37660d8b1160
Reviewed-on: https://chromium-review.googlesource.com/1101209
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569218}
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/browser/chromeos/login/screens/device_disabled_screen.cc
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/browser/chromeos/login/screens/device_disabled_screen.h
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/browser/chromeos/login/screens/device_disabled_screen_view.h
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/browser/chromeos/system/device_disabling_manager.cc
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/browser/chromeos/system/device_disabling_manager.h
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/browser/chromeos/system/device_disabling_manager_unittest.cc
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/browser/resources/chromeos/login/screen_device_disabled.js
[modify] https://crrev.com/7d6721f24a5e330bb14212bf953f6e28b0c59fa2/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc

Labels: M-69
Status: Fixed (was: Assigned)

Sign in to add a comment