New issue
Advanced search Search tips

Issue 852263 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-20
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Inconsistent behaviour is seen on opening a new tab from today's view in Recent tabs screen

Project Member Reported by pmadalla@chromium.org, Jun 13 2018

Issue description

App Version: 69.0.3456.0 canary
iOS Version: 10.3.3,iOS 11.4
Device: iPhone,iPad

Steps to reproduce:
  1. Launch chrome. 
  2. Sign in to chrome and wait for the devices to sync.
  3. Tap on tabswithcer > tap on Other devices icon.
  4. Long tap on the arrow on synced devices.
  5. Send the app to background.
  6. Open Newtab from todays view or 3d touch 
  7. Tap on Cancel in the popup.
  8. Navigate back to Normal tab.
  9. Try to open any tab.

Observed results: 
At Step 6 : Newtab is not displayed
At Step 9 : Unable to open newtab.

Expected results: 
At Step 6 : New tab should be displayed

Number of times you were able to reproduce: 3/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA


Link to video/image:  
https://drive.google.com/file/d/10pvWzXM-7DK73otG2N0H0C9P5sYaDLDt/view?usp=sharing

 

Comment 1 by marq@chromium.org, Jun 13 2018

Components: UI>Browser>Mobile>TabSwitcher
Labels: -Pri-2 -MS-Recent-Tabs MS-Tab-Grid Q2 Pri-1
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by edchin@chromium.org, Jun 15 2018

NextAction: 2018-06-20
Status: Started (was: Assigned)
CL in-flight.

Comment 3 by edchin@chromium.org, Jun 15 2018

Labels: small
The NextAction date has arrived: 2018-06-20

Comment 5 by edchin@chromium.org, Jun 20 2018

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eba3256439e754f69820fe035dead4920b683e2e

commit eba3256439e754f69820fe035dead4920b683e2e
Author: edchin <edchin@chromium.org>
Date: Wed Jun 20 18:35:37 2018

[ios] Dismiss recent tabs context menu from tab grid

Previously, opening a new tab search from today view or 3d touch would
put the tab grid in an invalid state, if the context menu was showing.
The new tab would not show, and the UI was no longer interactable.
The cause was that the context menu was not being dismissed.

This CL properly dismisses the recent tabs context menu on top of the
tab grid.

Bug:  852263 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2607f3ba4012d397f5ffc2faa4bb190c1fc980ba
Reviewed-on: https://chromium-review.googlesource.com/1102193
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568943}
[modify] https://crrev.com/eba3256439e754f69820fe035dead4920b683e2e/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Status: Verified (was: Fixed)
Verified the issue on the build 69.0.3497.33 beta tested on the device iPhone7+(11.4.1)
New tab is displayed on opening a newtab in recent tabs popups, works fine.

Sign in to add a comment