New issue
Advanced search Search tips

Issue 852262 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : Text overlaps with close button in chrome://settings/languages.

Reported by rp...@etouch.net, Jun 13 2018 
Chrome version: 69.0.3457.0 (Official Build)Revision 023848d56064d67203c53d8c9e70b3bb5c26ddbd-refs/branch-heads/3457@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/languages
2. Now expand 'Languages' section and click on 'Add languages' to open overlay.
3. Now right click on 'Search languages' text field and change 'Writing direction' Right to left and type any text,observe
 
Actual: Text overlaps with close button
Expected: Text shouldn't overlap with close button

This is regression issue, broken in ‘M 69’ and will soon update other info :
Good build: 69.0.3456.0  (Revision: 566382).
Bad build: 69.0.3457.0 (Revision: 566678).
Actual_video.mp4
291 KB View Download
Expected_video.mp4
296 KB View Download

Comment 1 by rp...@etouch.net, Jun 13 2018

Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 566530 (known good), but no later than 566531 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/8f68ca7f55a3606bf2a3c4ae836471a2f0536f3b..a28431dbf4972895460f4a085da668eb7e255826

Suspect : https://chromium.googlesource.com/chromium/src/+/a28431dbf4972895460f4a085da668eb7e255826

From the CL above, assigning the issue to the concern owner 

@scottchen- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thanks!

Comment 2 by rp...@etouch.net, Jun 13 2018

Labels: RegressedIn-69

Comment 3 by dpa...@chromium.org, Jun 13 2018

Labels: -Pri-1 Pri-3

Comment 4 by scottchen@chromium.org, Jun 13 2018

Owner: ----
Status: Available (was: Assigned)
FYI, there is code in place to take care of the entire page being RTL, but not when only a single input is made RTL at runtime.

This is related to how padding is done here: https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_page/settings_subpage_search.html?type=cs&q=settings_subpage_search&sq=package:chromium&g=0&l=28
►

Sign in to add a comment