AEC3: Echo leakage in moderately reverberant environments |
|||||||
Issue descriptionFor moderately reverberant environments, AEC3 has been shown to leak echoes due to the default length of the linear filter being too short.
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b29b52eedf21ad5a0c717806e9928dfa935ef0fd commit b29b52eedf21ad5a0c717806e9928dfa935ef0fd Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Jun 14 00:00:21 2018 Roll src/third_party/webrtc 789221f1101a..aeb0a6475bcc (7 commits) https://webrtc.googlesource.com/src.git/+log/789221f1101a..aeb0a6475bcc git log 789221f1101a..aeb0a6475bcc --date=short --no-merges --format='%ad %ae %s' 2018-06-13 peah@webrtc.org AEC3: Increase the range of reported echo path delay metrics 2018-06-13 magjed@webrtc.org Android: Fix VideoTrack behavior for adding/removing VideoSinks 2018-06-13 nisse@webrtc.org Replace all use of rtc::Pathname in generator_unittest.cc. 2018-06-13 danilchap@webrtc.org Introduce list of fields to put into codec agnostic descriptor 2018-06-13 devicentepena@webrtc.org AEC3: Changes to how the reverberation decay is applied. 2018-06-13 jonasolsson@webrtc.org Remove "webrtc_rtp" traces. 2018-06-13 yura.yaroshevich@gmail.com Add ow2_asm license Created with: gclient setdep -r src/third_party/webrtc@aeb0a6475bcc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= chromium:850538 , chromium:852257 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I96d3ed7b7c4bd9a705edda10c15a74623ce6505c Reviewed-on: https://chromium-review.googlesource.com/1099915 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567052} [modify] https://crrev.com/b29b52eedf21ad5a0c717806e9928dfa935ef0fd/DEPS
,
Jun 14 2018
,
Jun 18 2018
We would like to merge this improvement to AEC3 (Acoustic Echo Canceller 3). The code is part of Canary since 2018-06-14 and can be remotely deactivated if something goes wrong. The CL to merge: https://webrtc-review.googlesource.com/82161
,
Jun 18 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 18 2018
This CL is very large to merge into M68 at this point. However, if it can be completely disabled/fully on the server side if something goes wrong, then we can approve it. Please confirm again.
,
Jun 19 2018
Yes, the change can easily be completely disabled from the server side. The change fixes issues found during beta testing.
,
Jun 20 2018
As gustaf@ said, the fix can easily be disabled using kill-switches. In addition, the change only affects the new AEC3, which is in itself behind a flag and default disabled. We're currently putting a lot of effort into improving echo cancellation for all users in Chrome, and are tracking an aggressive plan. Your continued support for our effort is highly appreciated. Thanks!
,
Jun 20 2018
Approving merge to M68, as it's confirmed this can be disabled server side. Branch:3440
,
Jun 25 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 26 2018
The change has been merged to M68: https://webrtc-review.googlesource.com/c/src/+/84582
,
Jun 28 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 29 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2018