New issue
Advanced search Search tips

Issue 852247 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Tab grid panel scrolling has become jenky

Project Member Reported by edchin@chromium.org, Jun 13 2018

Issue description

Go to tab grid.
Scroll around.
See that it is jenky.
The scroll stop positions are between panels.

Video:
https://drive.google.com/open?id=1YVcfRgXSEld-YA6MAFO8x-Ivjv2dPKcl
 

Comment 1 by marq@chromium.org, Jun 13 2018

NextAction: 2018-06-20

Comment 2 by marq@chromium.org, Jun 13 2018

 Issue 852315  has been merged into this issue.

Comment 3 by marq@chromium.org, Jun 13 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/062ca4c12e9fb744fb82a4a58cec3911a43d511d

commit 062ca4c12e9fb744fb82a4a58cec3911a43d511d
Author: Mark Cogan <marq@google.com>
Date: Wed Jun 13 17:52:22 2018

[iOS] Fix scroll view jumping in tab grid.

A previous CL arranged for the current panel of the tab grid to update
whenever the view layout was updated; this happens frequently when
scrolling, which results in a "jump" as soon as the scroll view passes
the threshold for changing panels. This CL fixes that.

Bug:  852247 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7b2e56fdafff5cf156475563f04c5db0fd8964e6
Reviewed-on: https://chromium-review.googlesource.com/1099378
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566902}
[modify] https://crrev.com/062ca4c12e9fb744fb82a4a58cec3911a43d511d/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Comment 5 by marq@chromium.org, Jun 14 2018

Status: Fixed (was: Started)

Comment 6 by marq@chromium.org, Jun 14 2018

Labels: small

Comment 7 by marq@chromium.org, Jun 14 2018

Status: Started (was: Fixed)
Just tested this on canary and it still isn't right :-/
The NextAction date has arrived: 2018-06-20
Labels: -Pri-0 Pri-1

Comment 10 by marq@chromium.org, Jun 25 2018

Cc: martijnb@chromium.org marq@chromium.org mard...@chromium.org
 Issue 856184  has been merged into this issue.

Comment 11 by marq@chromium.org, Jun 27 2018

NextAction: 2018-07-04
Moving open tasks to the current sprint.

Comment 12 by marq@chromium.org, Jun 27 2018

NextAction: ----

Comment 13 by marq@chromium.org, Jun 27 2018

Owner: edchin@chromium.org
Load shedding bugs to Ed.
Status: Fixed (was: Started)
This looks fixed to me. 

Sign in to add a comment