New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852242 link

Starred by 1 user
Status: Fixed
Owner:
█ xiaoyinh@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
zalcorn@chromium.org
r...@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 809715


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Feedback reports on login screen don't work with the views-based version

Project Member Reported by satorux@google.com, Jun 13 2018 
Chrome Version       : 69.0.3455.1
OS Version: 10775.0.0

What steps will reproduce the problem?
1. Boot
2. Press Shift-Alt-i in the login screen

What is the expected result?

Feedback dialog pops up

What happens instead of that?

Nothing happens if the views-based login screen is enabled.
With the WebUI version, Shift-Alt-i works.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 10775.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3455.1 Safari/537.36

Comment 1 by satorux@chromium.org, Jun 13 2018

Blocking: 809715

Comment 2 by r...@chromium.org, Jun 13 2018

Cc: -jdufault@chromium.org r...@chromium.org
Labels: -Pri-2 ReleaseBlock-Beta Pri-1
Owner: jdufault@chromium.org
Jacob could you find someone to take a look at this? This probably should be looked at right away, since it'll block us from getting Feedback on the new login screen.

Comment 3 by jdufault@chromium.org, Jun 13 2018

Cc: jdufault@chromium.org
Owner: xiaoyinh@chromium.org

Comment 4 by xiaoyinh@chromium.org, Jun 13 2018 

The webui saves various keyboard shortcuts in WebUILoginView:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/webui_login_view.cc?rcl=d45eb35c0c7caeab16d19a67b404a64af3c0c536&l=144

views login screen should support this as well.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b02780531c2986c564a369263e55fc74596d74b9

commit b02780531c2986c564a369263e55fc74596d74b9
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Fri Jun 15 23:51:29 2018

Support feedback keyboard shortcut in views login screen.

This CL supports alt+shift+i to open the feedback dialog in views login
screen.

Bug:  852242 
Change-Id: I9a285c6929fd2302d22f90fbefbb32bcd814359d
Reviewed-on: https://chromium-review.googlesource.com/1102035
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567829}
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/ash/login/login_screen_controller.cc
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/ash/login/login_screen_controller.h
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/b02780531c2986c564a369263e55fc74596d74b9/chrome/browser/ui/ash/login_screen_client.h

Comment 6 by xiaoyinh@chromium.org, Jun 16 2018

Status: Fixed (was: Assigned)

Comment 7 by satorux@google.com, Jun 16 2018 

That was quick. Thanks!
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47a732b081e2ee058b57be3726a46931b507fae1

commit 47a732b081e2ee058b57be3726a46931b507fae1
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Jun 18 05:56:48 2018

Revert "Support feedback keyboard shortcut in views login screen."

This reverts commit b02780531c2986c564a369263e55fc74596d74b9.

Reason for revert: UserAddingScreenTest.ScreenVisibility has been
flaky since this landed:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=UserAddingScreenTest.ScreenVisibility

[28936:28936:0617/213745.316026:FATAL:accelerator_manager.cc(32)] Check failed: !base::ContainsValue(targets, target). Registering the same target multiple times
#0 0x000004980f5c base::debug::StackTrace::StackTrace()
#1 0x000004902b4b logging::LogMessage::~LogMessage()
#2 0x000005857d49 ui::AcceleratorManager::Register()
#3 0x000001ca3442 chromeos::WebUILoginView::WebUILoginView()
#4 0x000001c9a51c chromeos::LoginDisplayHostWebUI::InitLoginWindowAndView()
#5 0x000001c98cc5 chromeos::LoginDisplayHostWebUI::OnStartUserAdding()
#6 0x000001ca20c7 chromeos::(anonymous namespace)::UserAddingScreenImpl::Start()
#7 0x0000015dfd1c chromeos::UserAddingScreenTest_ScreenVisibility_Test::RunTestOnMainThread()
#8 0x000004f449b7 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()

Original change's description:
> Support feedback keyboard shortcut in views login screen.
>
> This CL supports alt+shift+i to open the feedback dialog in views login
> screen.
>
> Bug:  852242 
> Change-Id: I9a285c6929fd2302d22f90fbefbb32bcd814359d
> Reviewed-on: https://chromium-review.googlesource.com/1102035
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567829}

TBR=xiyuan@chromium.org,tsepez@chromium.org,jdufault@chromium.org,xiaoyinh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  852242 ,  853445 
Change-Id: I21afadf31af3c9ae8e04a30f6021b928efde43f8
Reviewed-on: https://chromium-review.googlesource.com/1103957
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567935}
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/ash/login/login_screen_controller.cc
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/ash/login/login_screen_controller.h
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/47a732b081e2ee058b57be3726a46931b507fae1/chrome/browser/ui/ash/login_screen_client.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0007c9356e793b1a5a1ae3e6b83a45c838668e78

commit 0007c9356e793b1a5a1ae3e6b83a45c838668e78
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Mon Jun 18 20:21:04 2018

Reland: Support feedback keyboard shortcut in views login screen

This CL supports alt+shift+i to open the feedback dialog in views login
screen.

TBR=tsepez@chromium.org

Bug:  852242 
Change-Id: I5d124422ade0f1b8f2698520c2cafd7cd7d27382
Reviewed-on: https://chromium-review.googlesource.com/1102035
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567829}
Reviewed-on: https://chromium-review.googlesource.com/1104895
Cr-Commit-Position: refs/heads/master@{#568135}
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/ash/login/login_screen_controller.cc
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/ash/login/login_screen_controller.h
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/0007c9356e793b1a5a1ae3e6b83a45c838668e78/chrome/browser/ui/ash/login_screen_client.h
►

Sign in to add a comment