New issue
Advanced search Search tips

Issue 852230 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Cannot history navigate back using fourth mouse button in bad SSL cert interstitial

Reported by mr.ber...@gmail.com, Jun 13 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36

Steps to reproduce the problem:
1. Have a mouse with fourth (maybe fifth) mouse button
2. Be used to navigate back (and forth) in history using fourth (and fifth) mouse button
3. Open a web site with a bad SSL certificta, such as https://expired.badssl.com/
4. While mouse is hovering the content of the error message, press Mouse4

What is the expected behavior?
History navigation backwards

What went wrong?
Nothing happens

Did this work before? N/A 

Chrome version: 67.0.3396.87  Channel: stable
OS Version: 10.0
Flash Version: 

It does work if I hover, e.g., the Omnibox or the bookmarks bar before pressing Mouse4. The bad SSL error message seems to be capturing the Mouse4 click.

This may or may not be related to Issue 850847, which is the same behavior in the pdf plugin.
 
Labels: Needs-Triage-M67
Cc: vamshi.kommuri@chromium.org
Components: -UI UI>Browser>Navigation
Labels: Triaged-ET TE-Hardware-Dependency
Thanks for filing the issue!

As we do not have mouse with 4/5 buttons hence adding label "TE-Hardware-Dependency" and requesting some one from respective team to have a look into this.
Tentatively adding component "UI>Browser>Navigation", please change if this isn't apt.
Components: UI>Browser>Interstitials
Labels: -Needs-Triage-M67 OS-Chrome OS-Linux OS-Mac
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)
Same root cause as bug 850847, but not sure if this should be merged or fixed separately.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04add8c6cd47cbac836956d9db9d15ea64d34855

commit 04add8c6cd47cbac836956d9db9d15ea64d34855
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Aug 29 18:38:57 2018

Fix back mouse button on Interstitial pages

Since Interstitial pages don't allow navigation they can't be told to
go back from the renderer. Trap the back mouse button in the interstitial
page and handle it directly.

BUG= 852230 

Change-Id: Ibbd5d97a9bd692a0b431a19eb6466b0512e7bce5
Reviewed-on: https://chromium-review.googlesource.com/1194831
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587213}
[modify] https://crrev.com/04add8c6cd47cbac836956d9db9d15ea64d34855/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/04add8c6cd47cbac836956d9db9d15ea64d34855/content/browser/frame_host/interstitial_page_impl.h
[modify] https://crrev.com/04add8c6cd47cbac836956d9db9d15ea64d34855/content/browser/frame_host/interstitial_page_impl_browsertest.cc
[modify] https://crrev.com/04add8c6cd47cbac836956d9db9d15ea64d34855/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/04add8c6cd47cbac836956d9db9d15ea64d34855/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/04add8c6cd47cbac836956d9db9d15ea64d34855/content/browser/renderer_host/render_widget_host_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment