New issue
Advanced search Search tips

Issue 852216 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Leak detector found a memory leak with a focused form

Project Member Reported by yuzus@chromium.org, Jun 13 2018

Issue description

BlinkLeakDetector found a memory leak happening with a focused form.

Run “tools/perf/run_benchmark memory.leak_detection --browser=default” after adding this html to page_sets.py.
The entire document leaks over navigation.

This leak happens with about 2.7% of real world websites (tested with 10k websites).

<script type="text/javascript">
$(function() {
  $("input#url").focus();
});
</script>
<p><input type="text" id="url"></p>

 

Comment 1 by yuzus@chromium.org, Jun 13 2018

Description: Show this description

Comment 2 by yuzus@chromium.org, Jun 13 2018

Labels: -Pri-3 Pri-2
Summary: Leak detector found a memory leak with a focused form (was: Leak detector reports a false positive leak with a focused form)

Comment 3 by yuzus@chromium.org, Jun 13 2018

Description: Show this description

Comment 4 by yuzus@chromium.org, Jun 13 2018

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb6dc412b13ae7b6942a8731f67358b883d9ff45

commit cb6dc412b13ae7b6942a8731f67358b883d9ff45
Author: Yuzu Saijo <yuzus@chromium.org>
Date: Thu Jun 14 04:11:14 2018

ClearProgress cold_mode_requester_ in Deactivate

This CL intends to fix a memory leak happening with a focused input form.
This seems to be happening because spellchecker holds a cold_mode_requester_, which holds an input element.
Spellchecker is reused (kept alive) by a local frame, so whatever spellchecker has references to will leak over navigation.
Other references were cleared in Deactivate() but the element was not.

BUG= 852216 

Change-Id: I96a872bad6348d7e1d6a160d2aa88d2fe9ba77cd
Reviewed-on: https://chromium-review.googlesource.com/1096926
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567128}
[modify] https://crrev.com/cb6dc412b13ae7b6942a8731f67358b883d9ff45/third_party/blink/renderer/core/editing/spellcheck/idle_spell_check_callback.cc

Comment 6 by yuzus@chromium.org, Jun 18 2018

Status: Fixed (was: Assigned)

Sign in to add a comment