New issue
Advanced search Search tips

Issue 852196 link

Starred by 1 user
Status: Fixed
Owner:
cblume@chromium.org
Closed: Jun 2018
Cc:
vmi...@chromium.org
ericrk@chromium.org
piman@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 850728



Sign in to add a comment

glslang_test doesn't build

Project Member Reported by cblume@chromium.org, Jun 13 2018 
glslang_test depends on glslang-default-resource-limits which is missing a .cpp file.

This target is being build as part of a full Vulkan build. So enabling Vulkan by default requires fixing this.

Investigate & either fix or work around.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3096227c1c02fc32a63afd11f3f42d1b7e4102ff

commit 3096227c1c02fc32a63afd11f3f42d1b7e4102ff
Author: Chris Blume <cblume@chromium.org>
Date: Wed Jun 13 02:05:36 2018

Fix glslang_test build

glslang_test is only built in a Vulkan build. Since it doesn't build, it
prevents us from having Vulkan as part of the default build.

It appears like a file was renamed at some point and the BUILD.gn wasn't
updated to reflect this change since it wasn't being tested in the
default build.

This CL includes the newly renamed file and allows glslang_test to be
built and run again.

BUG= 852196 

Change-Id: I11507bd51996caed6280501f36556e17334bb1ba
Reviewed-on: https://chromium-review.googlesource.com/1098379
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566685}
[modify] https://crrev.com/3096227c1c02fc32a63afd11f3f42d1b7e4102ff/third_party/glslang/BUILD.gn

Comment 2 by cblume@chromium.org, Jun 13 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment