Download Infobar : Add punctuation between the main message and link text |
||||||||
Issue descriptionThere should be a period at the end of the downloading message. Also there should be exactly one space after the period and before the start of link text. e.g. Downloading file (200 MB). Details
,
Jun 13 2018
,
Jun 13 2018
This bug requires manual review: There is .grd file changes and we are only 40 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2018
Please verify in canary
,
Jun 13 2018
,
Jun 15 2018
Verified on canary.
,
Jun 15 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5290df5fb8aece41e6cc4d0c2d2acc402796da1 commit d5290df5fb8aece41e6cc4d0c2d2acc402796da1 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Jun 15 22:18:08 2018 Download infobar : Added punctuation after the message text Bug: 852174 Change-Id: I05fa4415575db7ed3617ff8e58e58177b837b3e2 Reviewed-on: https://chromium-review.googlesource.com/1098151 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566812}(cherry picked from commit 57b8e5c1489ede04930ad1d8f5691ff4768d5b9b) Reviewed-on: https://chromium-review.googlesource.com/1103357 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#382} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/d5290df5fb8aece41e6cc4d0c2d2acc402796da1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java [modify] https://crrev.com/d5290df5fb8aece41e6cc4d0c2d2acc402796da1/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/d5290df5fb8aece41e6cc4d0c2d2acc402796da1/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadInfoBarControllerTest.java
,
Jun 15 2018
,
Jun 15 2018
Verified on Chrome:69.0.3461.3 Device:Sony Xperia Z3(D5803)/6.0.1
,
Jun 18 2018
We need to re-test in M68 build
,
Jun 18 2018
Verified in M68-68.0.3440.30 build
,
Jun 18 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2018