New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852171 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 900653

Blocking:
issue 852161



Sign in to add a comment

dlc service: a client for it

Project Member Reported by xiaochu@chromium.org, Jun 12 2018

Issue description

 A d-bus client to send command to dlc_service. Mainly used for testing/dev purpose.
 
Blocking: 852161
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Blockedon: 900653
Cc: ahass...@chromium.org norvez@chromium.org xiaochu@chromium.org
Owner: chowes@google.com
Though the complete resolution of crbug.com/900653 still takes a while, this project should be unlocked now with https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1334494.


Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8703b8deda0f3f146f328dc8859c139cd36d948e

commit 8703b8deda0f3f146f328dc8859c139cd36d948e
Author: Colin Howes <chowes@google.com>
Date: Sat Dec 08 01:35:21 2018

dlcservice: Implement wrapper for GetInstalled

Adds a wrapper for dlcservice GetInstalled DBus API call.
dlcservice_util can retreive a list of installed DLC when invoked with
the --list flag.

BUG= chromium:852171 
TEST=Run the utility with/without DLCs installed.

Change-Id: I42ee8f6c61e2483b291a9a10d1ac49d6ba1c458d
Reviewed-on: https://chromium-review.googlesource.com/1351235
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/8703b8deda0f3f146f328dc8859c139cd36d948e/dlcservice/tools/dlc_service_util.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/780f7ea0ad0a44b442f00a260cad3f5b17b1e6eb

commit 780f7ea0ad0a44b442f00a260cad3f5b17b1e6eb
Author: Colin Howes <chowes@google.com>
Date: Sat Dec 08 01:35:21 2018

dlcservice: Add a wrapper client utility around dlcservice.

Adds a wrapper utility around dlcservice that can install, update, and
get a list of already installed DLC. Just a dummy program for now, just
runs and exits.

BUG= chromium:852171 
TEST=Run the client with lists of DLCs.
CQ-DEPEND=CL:1347203

Change-Id: I0fd4265f515ed8664de309e6b7071adfbfd03089
Reviewed-on: https://chromium-review.googlesource.com/1351400
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/780f7ea0ad0a44b442f00a260cad3f5b17b1e6eb/dlcservice/BUILD.gn
[add] https://crrev.com/780f7ea0ad0a44b442f00a260cad3f5b17b1e6eb/dlcservice/tools/dlc_service_util.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2b53abd989d3c2ce965287e337103b08b81a2c7a

commit 2b53abd989d3c2ce965287e337103b08b81a2c7a
Author: Colin Howes <chowes@google.com>
Date: Sat Dec 08 01:35:21 2018

dlcservice: Implement wrapper for Install

Adds a wrapper for Install dlcservice API call. dlcservice_util can
be used to install a list of DLC specified using the --install flag.

BUG= chromium:852171 
TEST=Use the utility to install a DLC.

Change-Id: I1ce2971aa886f167faf7dc62ae4055f5f46282db
Reviewed-on: https://chromium-review.googlesource.com/1352187
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/2b53abd989d3c2ce965287e337103b08b81a2c7a/dlcservice/tools/dlc_service_util.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9ea67f7826f5e8d2cc7594d075de3dc76310538c

commit 9ea67f7826f5e8d2cc7594d075de3dc76310538c
Author: Colin Howes <chowes@google.com>
Date: Sat Dec 08 01:35:22 2018

dlcservice: Implement wrapper for Uninstall

Adds a wrapper for Uninstall dlcservice API. dlcservice_util can
uninstall a list of DLC specified by the --uninstall flag.

BUG= chromium:852171 
TEST=Use the utility to uninstall a DLC

Change-Id: I274531e2210b5346025f4276240b3121aafba8e6
Reviewed-on: https://chromium-review.googlesource.com/1352219
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/9ea67f7826f5e8d2cc7594d075de3dc76310538c/dlcservice/tools/dlc_service_util.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1520a5ebd2c9bf40161cab9cef23b1868058784c

commit 1520a5ebd2c9bf40161cab9cef23b1868058784c
Author: Colin Howes <chowes@google.com>
Date: Sat Dec 08 01:35:23 2018

dlcservice: Refactor and cleanup for dlcservice_util.

Clean up dlcservice_util to improve testability, readability.

BUG= chromium:852171 
TEST=Use dlcservice_util to install, uninstall, list installed DLC
modules. Also test failure paths where possible.

Change-Id: Iff230ecdd8a6ad1cc059a2b135aabd0c6167fbe3
Reviewed-on: https://chromium-review.googlesource.com/1355512
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/1520a5ebd2c9bf40161cab9cef23b1868058784c/dlcservice/tools/dlc_service_util.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6c9f9bc75ab70de145707914983b11acbb1d9f42

commit 6c9f9bc75ab70de145707914983b11acbb1d9f42
Author: Colin Howes <chowes@google.com>
Date: Sat Dec 08 01:35:22 2018

dlcservice: Add dlcservice_util to dlcservice ebuild.

Add dlcservice_util to dlcservice ebuild. It will be installed to
/usr/local/bin/. We want to avoid adding a new ebuild for the
dlcservice_util, but in order to add it to the dlcservice ebuild we
have to get rid of the runtime dependency of dlcservice-client on
dlcservice and add a compile-time dependency on dlcservice-client to
dlcservice. This is a similar pattern to what is used in
update_engine.

BUG= chromium:852171 
TEST=Build dlcservice, client utility is installed to /usr/local/bin/.
CQ-DEPEND=CL:1351400

Change-Id: I06cf4da19e752de7297ceb546e72bec9648e98c6
Reviewed-on: https://chromium-review.googlesource.com/1347203
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/6c9f9bc75ab70de145707914983b11acbb1d9f42/chromeos-base/dlcservice/dlcservice-9999.ebuild
[modify] https://crrev.com/6c9f9bc75ab70de145707914983b11acbb1d9f42/chromeos-base/dlcservice-client/dlcservice-client-9999.ebuild

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/19fc1984a7d95605bedcf83d8dfc5f1606bd043e

commit 19fc1984a7d95605bedcf83d8dfc5f1606bd043e
Author: Colin Howes <chowes@google.com>
Date: Fri Dec 14 06:59:17 2018

dlcservice: Add a readme for dlcservice_util.

Add a readme for dlcservice_util.

BUG= chromium:852171 
TEST=None

Change-Id: I106056fdae0d1025f6ff087e2cb9dfdc850f4070
Reviewed-on: https://chromium-review.googlesource.com/1357314
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

[add] https://crrev.com/19fc1984a7d95605bedcf83d8dfc5f1606bd043e/dlcservice/tools/README.md

Status: Fixed (was: Assigned)

Sign in to add a comment