New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852165 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR Browsing - menu item text color is different than url text color.

Project Member Reported by dbbrooks@chromium.org, Jun 12 2018

Issue description

Chrome Version: 69.0.3455.0
OS: O
Device: Pixel 2
Headset: Daydream V2

What steps will reproduce the problem?
(1) Enter VR browsing.
(2) Open Chrome menu.
Read expectation below.
(3) Select "New incognito tab" to enter incognito mode.
(4) Open Chrome menu.

What is the expected result? Menu item text, e.g. "New incognito tab" should be the same color as the url text in the Omnibox.

What happens instead? They are slightly different colors.
 
reg.png
285 KB View Download
incog.png
110 KB View Download
Labels: Target-69
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb90ca9f67b893847a7cc1a050f4a0a17e98c8df

commit bb90ca9f67b893847a7cc1a050f4a0a17e98c8df
Author: Christopher Grant <cjgrant@chromium.org>
Date: Fri Jul 13 15:51:40 2018

VR: Correct the overflow menu text color

BUG= 852165 
R=mthiesse

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iace7240f1cde3669a319375d0269397d32ea3f22
Reviewed-on: https://chromium-review.googlesource.com/1136576
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574929}
[modify] https://crrev.com/bb90ca9f67b893847a7cc1a050f4a0a17e98c8df/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/bb90ca9f67b893847a7cc1a050f4a0a17e98c8df/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/bb90ca9f67b893847a7cc1a050f4a0a17e98c8df/chrome/browser/vr/ui_scene_creator.cc

Status: Fixed (was: Started)

Sign in to add a comment