New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852162 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MatchesURL / GetHostedAppByURL should support blob URLs

Project Member Reported by creis@chromium.org, Jun 12 2018

Issue description

ExtensionSet::GetHostedAppByURL calls URLPatternSet::MatchesURL, which calls URLPattern::MatchesURL.  That has hard-coded support for filesystem URLs (with a nested URL check from r135049), but it doesn't check for blob URLs.

url::Origin::Create has built-in support for obtaining the origin from a URL that might be a filesystem or blob URL, so it might be worth updating MatchesURL to use that or support blob URLs another way.

(One subtlety is that hosted apps may be restricted to a path on an origin in some cases, and that path is generally lost in filesystem and blob URLs.  It should be fine to address it the same way for both filesystem and blob, though, and this isn't a problem for hosted apps that apply to an entire origin.)

This is a followup to  issue 851503 .
 

Sign in to add a comment