New issue
Advanced search Search tips

Issue 852159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Task

Blocked on:
issue 851608

Blocking:
issue 840584



Sign in to add a comment

Web Audio Autoplay: auto-resume AudioContext when a node call start()

Project Member Reported by mlamouri@chromium.org, Jun 12 2018

Issue description

This allows many games to work.
 
Labels: -Type-Bug -Pri-3 Pri-1 Type-Task
Blockedon: 851608
Blocking: 840584
We should wait until  crbug.com/851608  is done.
I do not think it is reasonable to have arbitrary dependencies like this. We need this behaviour change to land.

Comment 4 by rtoy@chromium.org, Jun 13 2018

I think the review comments in the CL for this bug does indicate that this is the right dependency.  Things are getting measured for offline contexts when they should not be.
Things have never been measured for offline contexts. You misread my changes.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96195371060e54f69b31d0cdc58a84a99376357b

commit 96195371060e54f69b31d0cdc58a84a99376357b
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Jun 14 22:00:31 2018

Web Audio: allow AudioContext resume on node start().

Bug:  852159 
Change-Id: I6b6f9c3ed2c8117405923d19d1e2b6ffee3e681d
Reviewed-on: https://chromium-review.googlesource.com/1098140
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567436}
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/third_party/WebKit/LayoutTests/media/autoplay/webaudio-node-start.html
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/third_party/blink/renderer/modules/webaudio/audio_buffer_source_node.cc
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/third_party/blink/renderer/modules/webaudio/audio_context.cc
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/third_party/blink/renderer/modules/webaudio/audio_context.h
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/third_party/blink/renderer/modules/webaudio/audio_context_autoplay_test.cc
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/third_party/blink/renderer/modules/webaudio/audio_scheduled_source_node.cc
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/third_party/blink/renderer/modules/webaudio/base_audio_context.h
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/third_party/blink/renderer/modules/webaudio/offline_audio_context.h
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/96195371060e54f69b31d0cdc58a84a99376357b/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment