New issue
Advanced search Search tips

Issue 852156 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Re-enabling internet at the end of some AU tests is failing because ping is failing too soong

Project Member Reported by dhadd...@chromium.org, Jun 12 2018

Issue description

We check we are still online by pinging google.com

I am not giving the pings any time for delay and so sometimes it fails.

I will give it more time 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6e70aa86bc1be81be9de2e0b3e2a4ba9dfc6b25f

commit 6e70aa86bc1be81be9de2e0b3e2a4ba9dfc6b25f
Author: David Haddock <dhaddock@chromium.org>
Date: Fri Jun 15 17:57:47 2018

Improve reconnect network logic in autoupdate_OmahaResponse tests.

These tests rely on disconnecting and reconnecting the network.
Sometimes pinging after reconnecting the network is failing because all
pings are not returning before the deadline. Instead I will send less
pings and give them more time to return to ensure we are online. I will
also add an error message to make checking logs easier.

I will restart the DUT if update_engine is not idle.

BUG= chromium:852156 
TEST=autoupdate_OmahaResponse*

Change-Id: I8a8ec03617a57101843aa38ca5fa1ac1422d0aeb
Reviewed-on: https://chromium-review.googlesource.com/1098387
Commit-Ready: David Haddock <dhaddock@chromium.org>
Tested-by: David Haddock <dhaddock@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>

[modify] https://crrev.com/6e70aa86bc1be81be9de2e0b3e2a4ba9dfc6b25f/client/cros/update_engine/update_engine_test.py
[modify] https://crrev.com/6e70aa86bc1be81be9de2e0b3e2a4ba9dfc6b25f/client/site_tests/autoupdate_BadMetadata/autoupdate_BadMetadata.py
[modify] https://crrev.com/6e70aa86bc1be81be9de2e0b3e2a4ba9dfc6b25f/server/site_tests/autoupdate_OmahaResponse/autoupdate_OmahaResponse.py

Status: Verified (was: Assigned)

Sign in to add a comment