Context menu stops showing when right click on the secondary display |
||||||||
Issue descriptionWhat steps will reproduce the problem? (1)Connect Chromebook to an external display in extended mode (2)Right click the shelf item icon of Chrome browser on the external display What is the expected result? Context menu of the browser pops up near the shelf item. What happens instead? Nothing. I've spent several hours bisecting and pinpoint the culprit. https://chromium-review.googlesource.com/c/chromium/src/+/1077195
,
Jun 13 2018
Thanks for bisecting!
,
Jun 13 2018
Looks like this bug only reproduces for application menus, not context menus.
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9a165049a574d2a3bb7d4cb48526635843c9a35 commit f9a165049a574d2a3bb7d4cb48526635843c9a35 Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Jun 15 14:30:08 2018 cros: Fix menu positioning bug Fixes menu positioning miscalculations in MenuController. Bug: 852153 Change-Id: I494bf3b80e33712d515c1369a0fa1be9e3c3e90b Reviewed-on: https://chromium-review.googlesource.com/1101966 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#567639} [modify] https://crrev.com/f9a165049a574d2a3bb7d4cb48526635843c9a35/ui/views/controls/menu/menu_controller.cc
,
Jun 15 2018
Issue 840490 has been merged into this issue.
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cce253a7da5925f653f3aa3e399bfa017c1075d1 commit cce253a7da5925f653f3aa3e399bfa017c1075d1 Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Jun 22 22:49:51 2018 cros: Fix menu positioning bug Fixes menu positioning miscalculations in ShelfView, also refactors GetMenuAnchorRect so its more readable. Bug: 852153 Change-Id: Ie8c377de9b2191c3ae739f5adec7f16fc8003bd7 Reviewed-on: https://chromium-review.googlesource.com/1102028 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569816} [modify] https://crrev.com/cce253a7da5925f653f3aa3e399bfa017c1075d1/ash/shelf/shelf_view.cc [modify] https://crrev.com/cce253a7da5925f653f3aa3e399bfa017c1075d1/ash/shelf/shelf_view.h [modify] https://crrev.com/cce253a7da5925f653f3aa3e399bfa017c1075d1/ash/shelf/shelf_view_test_api.cc [modify] https://crrev.com/cce253a7da5925f653f3aa3e399bfa017c1075d1/ash/shelf/shelf_view_test_api.h [modify] https://crrev.com/cce253a7da5925f653f3aa3e399bfa017c1075d1/ash/shelf/shelf_view_unittest.cc
,
Jun 22 2018
This should be the last merge. This fixes the error where context menus were not showing on multi-display.
,
Jun 23 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 25 2018
,
Jun 25 2018
,
Jun 29 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 3
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by newcomer@chromium.org
, Jun 13 2018Status: Started (was: Untriaged)