Currently the bottom toolbar doesn't change color in response to theming or incognito mode.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3f4b4d222d1e28334bad0b6a262808668099600 commit f3f4b4d222d1e28334bad0b6a262808668099600 Author: Pedro Amaral <amaralp@chromium.org> Date: Thu Aug 16 19:25:51 2018 Add theming to the bottom toolbar Make the bottom toolbar take on the theme color. Also have the bottom toolbar buttons become light/dark depending on theme color. The main complexity of this patch arises from having to support two different ways for theming button icons. Some icons are tintable and in that case we can just set their tint to light or dark. Other icons aren't tintable and have 2 separate drawables and swap them out depending on the theme. There are a still an issue this patch doesn't address. If a site is themed and then we go to tab switcher mode the bottom toolbar will retain the original site's theming. To solve this we'll need a sane theme provider. Bug: 852140 Change-Id: I3ec960c1e5c7d83b663ee97101d6a11e528e4f95 Reviewed-on: https://chromium-review.googlesource.com/1166291 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583769} [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherButtonCoordinator.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherButtonProperties.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherButtonView.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherButtonViewBinder.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonSlotData.java [modify] https://crrev.com/f3f4b4d222d1e28334bad0b6a262808668099600/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbdb8eb3bfeedbd81366fbe9aeb4099155cd6b78 commit dbdb8eb3bfeedbd81366fbe9aeb4099155cd6b78 Author: Pedro Amaral <amaralp@chromium.org> Date: Wed Aug 29 18:47:00 2018 Only theme bottom toolbar with incognito mode Previously we were theming the bottom toolbar with the website specified theme color. After talking with UX we decided that it would only have the bottom toolbar color reflect whether incognito mode was enabled. This CL makes it so the bottom toolbar is light colored when incognito is not enabled and dark colored when it is enabled. Bug: 875870 , 852140 Change-Id: I839d2938209d463191892dcd3fe68c527bba44c2 Reviewed-on: https://chromium-review.googlesource.com/1192125 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#587218} [modify] https://crrev.com/dbdb8eb3bfeedbd81366fbe9aeb4099155cd6b78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java [modify] https://crrev.com/dbdb8eb3bfeedbd81366fbe9aeb4099155cd6b78/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
Comment 1 by mdjones@chromium.org
, Aug 1