New issue
Advanced search Search tips

Issue 852139 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jul 24
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Use p-links for Cast help center articles

Project Member Reported by taku...@chromium.org, Jun 12 2018 
According to issue 679462, we should be using p-links instead of links with answer IDs. Once p-links have been generated, we should replace the following linksin chrome/common/url_constants.cc:

https://support.google.com/chromecast/answer/3249268
https://support.google.com/chromecast/answer/6320939
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15a19296951af69bee072ea0abf7e65e8e4ce49c

commit 15a19296951af69bee072ea0abf7e65e8e4ce49c
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue Jul 24 00:25:35 2018

Use p-links for Cast help articles

Replace help center URLs with p-links. There is no change in the actual
destination pages.

Bug:  852139 
Change-Id: I85176c6c2076d331ae58e10f7150ccf9c42da03e
Reviewed-on: https://chromium-review.googlesource.com/1147216
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577363}
[modify] https://crrev.com/15a19296951af69bee072ea0abf7e65e8e4ce49c/chrome/common/url_constants.cc

Comment 2 by taku...@chromium.org, Jul 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment