New issue
Advanced search Search tips

Issue 852130 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

crostc_perf: cannot parse json files

Project Member Reported by manojgupta@chromium.org, Jun 12 2018

Issue description

It appears that the format of telemetry result files have changed and they no longer have the fields with __http://* suffixes.

This causes crostsc_perf to complain about duplicate fields.

Rahul suggested (in IRC) to delete the logic pertaining to detailed results and just do the summary since no one is looking at detailed results
 

Comment 1 by lloz...@google.com, Jun 12 2018

can you provide more detail in here about what we would be loosing (I don't know how the details look)
AFAIK, detailed results include ALL of the metrics generated by the benchmark. But our dashboards however track only a smaller number of metrics (summarized results).

Lets say in future, we want to track a new metric X (for an existing benchmark) in our dashboards. Dropping detailed changes will prevent us from getting the old data about X.
(Not entirely correct since we also keep the original json files around. So we can regenerate CIO files with the data for metric X in theory).

Comment 3 by lloz...@google.com, Jun 14 2018

I would prefer we keep the detailed results.
Status: Verified (was: Untriaged)
I just submitted cl/200579858 that only skips detailed results for the benchmark smoothness.tough_webgl_cases.
Rest of the benchmarks are unaffected.

Sign in to add a comment