New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852114 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Try jobs for WebKit Mac10.10 and WebKit Mac10.11 failed

Project Member Reported by chanli@chromium.org, Jun 12 2018

Issue description

Comment 1 by chanli@chromium.org, Jun 12 2018

Cc: -robert...@chromium.org
Owner: robert...@chromium.org
Status: Assigned (was: Available)
Owner: chanli@chromium.org
After doing some debugging, it seems there is a mismatch in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/findit/api.py?rcl=db09bfd88610eccb25fb2677fe009db1ba0dad81&l=179

`test.name` as returned by chromium_tests.get_test is "webkit_layout_tests on (none) GPU on Mac" whereas the requested test is just "webkit_layout_tests" (as indicated in the property)

Chan will continue to look into this.

Comment 3 by chanli@chromium.org, Jun 13 2018

The reason for flake try jobs don't compile is what robertocn@ described in comment#2. A fix for that is coming.

The reason for the failed analyze step is because the os dimensions for WebKit Mac Builder and WebKit Mac Builder (dbg) need to be updated (Mac 10.11 to Mac 10.12). I have manually changed it in config. And later robertocn@ will have a change to dynamically update the mapping.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c5732354f108a350f73a9a8dea2b1d906aa1a22c

commit c5732354f108a350f73a9a8dea2b1d906aa1a22c
Author: Chan <chanli@chromium.org>
Date: Fri Jun 15 01:02:28 2018

[Findit] Use canonical step name when look for requested tests to run.

Bug:  852114 
Change-Id: Iaf81572af78008130e5d371c0983e2238a005fdf
Reviewed-on: https://chromium-review.googlesource.com/1100038
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/c5732354f108a350f73a9a8dea2b1d906aa1a22c/scripts/slave/recipe_modules/findit/api.py
[modify] https://crrev.com/c5732354f108a350f73a9a8dea2b1d906aa1a22c/scripts/slave/recipe_modules/chromium_tests/steps.py

Comment 5 by chanli@chromium.org, Jun 15 2018

Status: Fixed (was: Assigned)

Sign in to add a comment