Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Fixed
Owner:
Closed: Jun 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Security

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
Use after free in SVGUseElement::buildShadowTree
Reported by miau...@gmail.com, Jun 7 2011 Back to list



VERSION
Chrome Version: stable, & daily
Operating System: osx, linux

REPRODUCTION CASE
<svg>
<g>
<use xlink:href="#g"/>
</g>
<g id="g">
<script>
document.body.innerText = "";
</script>

FOR CRASHES, PLEASE INCLUDE THE FOLLOWING ADDITIONAL INFORMATION
Type of crash: renderer
Crash State: 

Address 0xf4ecb38 is 40 bytes inside a block of size 384 free'd
Address 0x4141414141414571 is not stack'd, malloc'd or (recently) free'd
at 0x183B1B0: WebCore::Node::dispatchSubtreeModifiedEvent() (Document.h:886)
by 0x17F3B5D: WebCore::ContainerNode::appendChild
 
svgx.html
98 bytes View Download
Comment 1 by miau...@gmail.com, Jun 7 2011
vg logs
vg-google-chrome.txt
7.2 KB View Download
vg-chromium-nightly.txt
19.8 KB View Download
Labels: -Pri-0 -Area-Undefined Pri-1 Area-WebKit SecSeverity-High OS-All Mstone-12
Status: Available
Awesome bug miaubiz.

filed webkit bug - https://bugs.webkit.org/show_bug.cgi?id=62225

Slightly more clear testcase::
<svg>
    <g>
        <use xlink:href="#test"/>
    </g>
    <rect id="test">
        <script>
            document.body.innerHTML = "PASS";
        </script>
    </rect>
</svg>
Owner: infe...@chromium.org
Status: Assigned
Summary: Use after free in SVGUseElement::buildShadowTree (was: NULL)
trying out a fix.
Status: Started
Cc: tonyg@chromium.org
Owner: simonjam@chromium.org
Cc: simonjam@chromium.org
Owner: infe...@chromium.org
Status: WillMerge
Committed r88549: <http://trac.webkit.org/changeset/88549>

We will merge to m12, m13 branches.
Labels: reward-topanel
Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
We should be uptaking fix from https://bugs.webkit.org/show_bug.cgi?id=62412 after the c#6 fix. This is a more proper fix as per Eric's comments.
lets just pick 88549 for now. the comprehensive fix in  bug 62412  has brought some crashes. http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r88585%20(583)/results.html
Labels: ReleaseBlock-Stable
Status: FixUnreleased
Merged 88549 to M12: http://trac.webkit.org/changeset/88836
and M13: http://trac.webkit.org/changeset/88837
Labels: -reward-topanel reward-1000 reward-unpaid CVE-2011-2351
@miaubiz: Interesting bug. Seems almost too simple :P Nice small repro, clear $1000 reward case.

----
Boilerplate text:
Please do NOT publicly disclose details until a fix has been released to all our
users. Early public disclosure may cancel the provisional reward.
Also, please be considerate about disclosure when the bug affects a core library
that may be used by other products.
Please do NOT share this information with third parties who are not directly
involved in fixing the bug. Doing so may cancel the provisional reward.
Please be honest if you have already disclosed anything publicly or to third parties.
----
Comment 13 by miau...@gmail.com, Jun 16 2011
@scarybeasts: I had this as a nullpointer and infinite recursion since december. but now it had become exploitable.  delightfully simple yes :)
Labels: -reward-unpaid
Invoice finalized; payment is in e-payment system; it can take a couple of weeks.
Labels: SecImpacts-Stable
Batch update.
Lifting view restrictions.
Labels: -Restrict-View-SecurityNotify
Lifting view restrictions.
Status: Fixed
Project Member Comment 19 by bugdroid1@chromium.org, Oct 13 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 20 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Type-Security -Area-WebKit -SecSeverity-High -Mstone-12 -SecImpacts-Stable Cr-Content Security-Severity-High Security-Impact-Stable M-12 Type-Bug-Security
Project Member Comment 21 by bugdroid1@chromium.org, Mar 13 2013
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Project Member Comment 22 by bugdroid1@chromium.org, Mar 21 2013
Labels: -Security-Severity-High Security_Severity-High
Project Member Comment 23 by bugdroid1@chromium.org, Mar 21 2013
Labels: -Security-Impact-Stable Security_Impact-Stable
Project Member Comment 24 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content Cr-Blink
Project Member Comment 25 by sheriffbot@chromium.org, Oct 1 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member Comment 26 by sheriffbot@chromium.org, Oct 2 2016
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: allpublic
Sign in to add a comment