After focusing text field, bottom toolbar floating in middle of screen |
||
Issue description- Go to google results page - Focus search box on page (not omnibox) - Hide keyboard Bottom toolbar is left floating in the middle of the screen.
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e70c451f31134bffd1fe4d06d30d924db3e9e8c commit 3e70c451f31134bffd1fe4d06d30d924db3e9e8c Author: Matthew Jones <mdjones@chromium.org> Date: Mon Jul 16 22:03:07 2018 Hide bottom toolbar while keyboard is showing This patch adds the ability of the bottom toolbar to hide while the keyboard is showing. This patch is able to use existing simpler infra (KeyboardVisibilityListener) to solve this problem because we are trying to hide UI rather than show it on top of the keyboard. The challenge with showing UI above the keyboard is the inconsistency of the signals that we receive (with keyboard modes like PAN, RESIZE, etc.). If we receive no visibility signal, the keyboard simply draws on top of the bottom toolbar (making it invisible). In the more reliable case where the screen is resized, we hide the bottom toolbar's components and tell the renderer that the bottom controls height is 0. Bug: 852109 , 860071 Change-Id: I056c47bea33dd426f3b488925ff169735ac95c2f Reviewed-on: https://chromium-review.googlesource.com/1125326 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#575443} [modify] https://crrev.com/3e70c451f31134bffd1fe4d06d30d924db3e9e8c/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java [modify] https://crrev.com/3e70c451f31134bffd1fe4d06d30d924db3e9e8c/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ScrollingBottomViewSceneLayer.java [modify] https://crrev.com/3e70c451f31134bffd1fe4d06d30d924db3e9e8c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java [modify] https://crrev.com/3e70c451f31134bffd1fe4d06d30d924db3e9e8c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java [modify] https://crrev.com/3e70c451f31134bffd1fe4d06d30d924db3e9e8c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java [modify] https://crrev.com/3e70c451f31134bffd1fe4d06d30d924db3e9e8c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java [modify] https://crrev.com/3e70c451f31134bffd1fe4d06d30d924db3e9e8c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
,
Jul 16
|
||
►
Sign in to add a comment |
||
Comment 1 by mdjones@chromium.org
, Jul 3Owner: mdjones@chromium.org
Status: Started (was: Available)