NTP icons (Bookmarks/Reading List/Recent Tabs/History) disappear on removing most popular icons |
|||||||||
Issue descriptionApp Version: 69.0.3456.0 Canary iOS Version: 11.4.1 Device: iPad pro Steps to reproduce: 1. Launch chrome 2. Remove most popular icons 3. Open New Tab page Observed results: NTP icons (Bookmarks/Reading List/Recent Tabs/History) disappear on removing most popular icons Expected results: NTP icons (Bookmarks/Reading List/Recent Tabs/History) should be present when removing most popular icons Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Link to video/image: https://drive.google.com/file/d/19K6yVMlK0rHRjSFA6xdI1qm3LTmH6rop/view
,
Jun 19 2018
,
Jun 20 2018
,
Jun 21 2018
,
Jun 26 2018
,
Jun 27 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4 commit 4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4 Author: Justin Cohen <justincohen@google.com> Date: Wed Jun 27 15:17:51 2018 [ios] Various NTP fixes for UI Refresh. -Fix tapping NTP action cells when omnibox is focused. -Do not remove action items when most visited is empty. -Disable dynamic type sizes on most visited and action items. -Fix omnibox visibility on iPad when search provider changes. Bug: 846764 , 852108 , 850469, 848762 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie1c38be47fb9a60325387a78f55eb1a548dae831 Reviewed-on: https://chromium-review.googlesource.com/1110148 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570777} [modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_cell.mm [modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm [modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm [modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm [modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/4eaca7cab78c60fdd8906ce9d643fa71aeb5b2d4/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm
,
Jun 27 2018
,
Jul 3
Verified in 69.0.3480.0 Canary, iPhone X iOS 11.4, iPad Air iOS11.4 Looks good
,
Jul 13
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by marq@chromium.org
, Jun 13 2018Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)