New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852105 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Photos lost after copying to Team Drive and deleting folder

Project Member Reported by sashab@chromium.org, Jun 12 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: ChromeOS

What steps will reproduce the problem?
(1) Move files from camera to computer
(2) Trust Files to sync photos to Drive
(3) Go into Drive and move the photos to team drive
(4) Delete folder in Drive

What is the expected result?

Photos are available in Drive Trash, or Chromebook Trash, or similar

What happens instead?

* Not all photos had been synced yet
* Local folder has been permanently deleted
* Fail to find a Chromebook trash

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 

Comment 1 by sashab@chromium.org, Jun 14 2018

Cc: henck@google.com
To clarify what happened:

(1) Plug in an SD card with a folder full of photos
(2) Drag-drop the folder from the SD card to Drive folder in Files app
(3) Open drive.google.com
(4) Copy the folder that was copied to a Team Drive
(5) Delete the original folder

Now the files are permanently lost.

Comment 2 by henck@google.com, Jun 15 2018

Specifically, the files weren't uploaded yet but it was hard for me to know that without checking the file counts manually.

It seems like there are at least three possible UX changes that could help prevent this:
1) Don't delete anything that hasn't been uploaded
2) Add a trash if anything local-only is deleted
3) Give a visual indicator that a folder is still uploading like we do on other OSes


Comment 3 by sashab@chromium.org, Jun 17 2018

Weifang, can you confirm our plans for these suggestions? I'm pretty sure we're working on 1 with the new Drive sync and 3 with the visual indicators work. Are there plans to add a Trash to ChromeOS?
To confirm - Improving our visual indicators on the file progress/activity is definitely on our roadmap. By adding more UI around this, it may introduce an additional confirmation dialog in the case where a user attempts to remove files that are not in a completely uploaded state.

Currently, there are no plans to add a Trash to Chrome OS.

Comment 5 by henck@google.com, Jun 21 2018

Thanks for the details.  

To clarify, the case of files getting deleted is that the folder is removed from the web UI, and the sync process (not the user) deletes the local files, which IMHO should not happen without confirmation.  It sounds like the UI you're suggesting would be to prompt before allowing the user to delete the files locally, which is yet another case.
Owner: ----
Status: Available (was: Assigned)
Will revisit when DriveFS lands, it will internally move things to trash so the semantics will be different.
Thanks for the update - that seems like it would be a reasonable experience for my situation.
Status: WontFix (was: Available)
This issue is no longer applicable under the new sync engine, even if you delete it still uploads the files so it can trash them rather than straight delete them.
This is great news, thanks!

Sign in to add a comment