This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67b738e150fef9d9581099c121b4cb12c00834ea

commit 67b738e150fef9d9581099c121b4cb12c00834ea
Author: Christian Fremerey <chfremer@chromium.org>
Date: Thu Jun 14 18:18:03 2018

[Video Capture] Fix dangerous silent remapping of video pixel format

Added all video pixel formats from media::VideoPixelFormat to
media::mojom::VideoCapturePixelFormat.

Updated Mojo typemapping to have a 1:1 mapping between the two.


A recent CL https://chromium-review.googlesource.com/c/chromium/src/+/1026795
caused a regression by introducing a new mojo enum VideoCapturePixelType and
typemapping it to media::VideoPixelFormat, see crbug/839742.

A quick mitigation fix was landed and merged into M68. However, the fix is
specific to a particular single format. The current state still has the danger
of having produced similar regressions occurring for other formats, which may
simply not yet have surfaced.


Using TBR since this has been reviewed previously at
https://chromium-review.googlesource.com/c/chromium/src/+/1050489

TBR=xhwang@chromium.org,rockot@chromium.org,sandersd@chromium.org,rsesek@chromium.org,chfremer@chromium.org,lasoren@chromium.org

Bug:  852096 
Change-Id: I6f6d3add996d3557f33fbd42084ad2a9844b5957
Reviewed-on: https://chromium-review.googlesource.com/1098143
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567347}
[modify] https://crrev.com/67b738e150fef9d9581099c121b4cb12c00834ea/media/capture/mojom/video_capture_types.mojom
[modify] https://crrev.com/67b738e150fef9d9581099c121b4cb12c00834ea/media/capture/mojom/video_capture_types_mojom_traits.cc

Please mark which OS's this is impacting to route the merge request appropriately. 

Before we approve merge to M68, pls answer followings:
* Is change well baked/verified in canary and safe to merge?
* Is this feature behind finch, can be easily disable from server side if something goes wrong?
* Pls provide any additional merge justification.

* Is change well baked/verified in canary and safe to merge?

Yes

* Is this feature behind finch, can be easily disable from server side if something goes wrong?

No. This is not a new feature. It is a fix for potential regression introduced in 68.0.3419.0.

* Pls provide any additional merge justification.

This fix eliminates a dangerous behavioral change introduced in 68.0.3419.0. One regression caused by this has been mitigated with a partial fix. This fix covers the remaining cases. Without merging this we would risk potential regressions for these remaining cases going unnoticed and reaching the stable channel.

Approving merge to M68. Branch:3440

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbc50981cf92de161f4ffc29e6fe92e584b7337b

commit cbc50981cf92de161f4ffc29e6fe92e584b7337b
Author: Christian Fremerey <chfremer@chromium.org>
Date: Tue Jun 19 18:33:24 2018

[Video Capture] Fix dangerous silent remapping of video pixel format

Added all video pixel formats from media::VideoPixelFormat to
media::mojom::VideoCapturePixelFormat.

Updated Mojo typemapping to have a 1:1 mapping between the two.


A recent CL https://chromium-review.googlesource.com/c/chromium/src/+/1026795
caused a regression by introducing a new mojo enum VideoCapturePixelType and
typemapping it to media::VideoPixelFormat, see crbug/839742.

A quick mitigation fix was landed and merged into M68. However, the fix is
specific to a particular single format. The current state still has the danger
of having produced similar regressions occurring for other formats, which may
simply not yet have surfaced.


Using TBR since this has been reviewed previously at
https://chromium-review.googlesource.com/c/chromium/src/+/1050489

TBR=xhwang@chromium.org,rockot@chromium.org,sandersd@chromium.org,rsesek@chromium.org,chfremer@chromium.org,lasoren@chromium.org

Bug:  852096 
Change-Id: I6f6d3add996d3557f33fbd42084ad2a9844b5957
Reviewed-on: https://chromium-review.googlesource.com/1098143
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567347}(cherry picked from commit 67b738e150fef9d9581099c121b4cb12c00834ea)
Reviewed-on: https://chromium-review.googlesource.com/1106499
Cr-Commit-Position: refs/branch-heads/3440@{#447}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/cbc50981cf92de161f4ffc29e6fe92e584b7337b/media/capture/mojom/video_capture_types.mojom
[modify] https://crrev.com/cbc50981cf92de161f4ffc29e6fe92e584b7337b/media/capture/mojom/video_capture_types_mojom_traits.cc