Modernize save card dialogs |
||
Issue descriptionFeature description: Modernize the local/upstream save card dialogs to MD2 Eng owner: ftirelo Product owner: durgapandey Are you planning on experimenting before launch? This will be enabled with the upcoming UI changes experiment. Any new strings? No. Any implications for Google webservices (i.e. sync, translate)? No. Binary size? No change expected. Do the existing perf tests exercise all aspects of your new feature(s)? Yes.
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/964eea9da1632af18381389982b7947533ad0421 commit 964eea9da1632af18381389982b7947533ad0421 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Jun 14 03:17:46 2018 [Save card dialog] Add spacer between CC number and exp. date In the new dialog proposal, expiration date is aligned on the right for LTR language, and on the left for RTL languages. Bug: 852094 Change-Id: I255ad02c270bca3fc7f2fa548d54a4ec889d278b Reviewed-on: https://chromium-review.googlesource.com/1097938 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#567110} [modify] https://crrev.com/964eea9da1632af18381389982b7947533ad0421/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbbd9b766e3780f41257196537625c4e668bda1c commit dbbd9b766e3780f41257196537625c4e668bda1c Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Jun 14 05:27:11 2018 [Views] Adjust secondary info and link style colors for MD2 Source: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g399d5e0d81_22_0 Bug: 852094 Change-Id: I0bbfc28d214bed310fdb4a23cd804442d5751590 Reviewed-on: https://chromium-review.googlesource.com/1099560 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#567152} [modify] https://crrev.com/dbbd9b766e3780f41257196537625c4e668bda1c/chrome/browser/ui/views/harmony/harmony_typography_provider.cc [modify] https://crrev.com/dbbd9b766e3780f41257196537625c4e668bda1c/ui/native_theme/common_theme.cc
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/474b0b5fe4417cdb4da97a2f482117997c859273 commit 474b0b5fe4417cdb4da97a2f482117997c859273 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Tue Jun 19 21:03:22 2018 [Save card dialog] Change label styles Sets the style for explanation, footer disclaimer, and expiration dates to secondary, in order to match the new spec. Also sets style for credit card number as primary. Sets context for labels as CONTEXT_BODY_TEXT_LARGE, so that they get the correct font size (13dp). Also changes the disclaimer test in the DialogBrowserTest to make it easier to inspect link changes. Bug: 852094 Test: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Server --test-launcher-interactive Change-Id: Ib9b7ef57119c1314848e079122f3677d5db80901 Reviewed-on: https://chromium-review.googlesource.com/1099486 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568601} [modify] https://crrev.com/474b0b5fe4417cdb4da97a2f482117997c859273/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc [modify] https://crrev.com/474b0b5fe4417cdb4da97a2f482117997c859273/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b987322c193d6c1f2ef1fa4e98a9d055fa6d48c commit 5b987322c193d6c1f2ef1fa4e98a9d055fa6d48c Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed Jun 20 15:06:48 2018 Revert "[Views] Adjust secondary info and link style colors for MD2" This reverts commit dbbd9b766e3780f41257196537625c4e668bda1c. Reason for revert: contrast ratio for links is below 4.5:1 threshold Original change's description: > [Views] Adjust secondary info and link style colors for MD2 > > Source: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g399d5e0d81_22_0 > > Bug: 852094 > Change-Id: I0bbfc28d214bed310fdb4a23cd804442d5751590 > Reviewed-on: https://chromium-review.googlesource.com/1099560 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567152} TBR=msw@chromium.org,estade@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852094 , 853637 Change-Id: I169e1f39d120c714e37c0534115d692a499c591f Reviewed-on: https://chromium-review.googlesource.com/1106457 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568845} [modify] https://crrev.com/5b987322c193d6c1f2ef1fa4e98a9d055fa6d48c/chrome/browser/ui/views/harmony/harmony_typography_provider.cc [modify] https://crrev.com/5b987322c193d6c1f2ef1fa4e98a9d055fa6d48c/ui/native_theme/common_theme.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/babfdd57c9df87a9fb9c1453d06d74453069782b commit babfdd57c9df87a9fb9c1453d06d74453069782b Author: Fabio Tirelo <ftirelo@chromium.org> Date: Wed Jun 20 18:25:09 2018 [Views] Adjust secondary info style colors for MD2 Source: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g399d5e0d81_22_0 This is a partial reland of https://crrev.com/c/1099560, reverted because it broke contrast ratio for links on the bookmarks bar. Bug: 852094 Change-Id: I968fc12dd5101993ac7473a246b9f73b8a39b1d8 Reviewed-on: https://chromium-review.googlesource.com/1108196 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568935} [modify] https://crrev.com/babfdd57c9df87a9fb9c1453d06d74453069782b/chrome/browser/ui/views/harmony/harmony_typography_provider.cc
,
Jul 12
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 13 2018