Make click target for top row in user menu be /people |
|||||
Issue descriptionCurrent user menu click target behavior: (1) When a user has not yet opted into sync, there's no link in the top section of the user menu at all. The entire top section is just a promo to turn on sync, so there's no tap target. (2) When a user is opted into sync and syncing normally, clicking on the top row links to chrome://settings/syncSetup. The rationale here is that if you click a row that says "Syncing to <account name>," it makes sense to bring you to the sync settings for that account. (3) When a user is opted into sync and not syncing normally (e.g. sync is paused due to an auth error), clicking on the top row links to chrome://settings. The rationale here is that if a user has paused sync by signing out of the content area, and they want to get rid of their identity completely, we will link them to a convenient spot to turn off sync and disconnect their account from Chrome. (1) is being addressed in Issue 852008 This bug is tracking an update for (2) and (3): instead of linking to chrome://settings/syncSetup in (2) and chrome://settings in (3), we should *always* link to chrome://settings/people (for both scenarios (2) and (3)). This should be a straightforward change that we can land directly on trunk.
,
Jun 15 2018
I think it was created from a template. This specific bug doesn't need to be restricted as far as I know. (If I'm wrong please change it back Eli :).)
,
Jun 15 2018
Maybe the template could be changed to default to public?
,
Jun 15 2018
The sign-in bugs we file in general are also related to GAIA, that's why I think we have erred on the side of being extra careful not to leak internal information about Gaia in public bugs. But I agree we should be more careful and make public the bugs that are public.
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f825aacdf4cbfe169b74235827ea0ef3f8c31dc8 commit f825aacdf4cbfe169b74235827ea0ef3f8c31dc8 Author: Thomas Tangl <tangltom@chromium.org> Date: Fri Jun 15 12:44:45 2018 [Dice] Change target of user menu profile card to settings/people When the user is signed into Chrome and clicks the profile card in the user menu, they are now directed to chrome://settings/people. Bug: 852092 Change-Id: I89c770869232956ae8fb00a61cad8ebb6375532f Reviewed-on: https://chromium-review.googlesource.com/1102422 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#567615} [modify] https://crrev.com/f825aacdf4cbfe169b74235827ea0ef3f8c31dc8/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc [modify] https://crrev.com/f825aacdf4cbfe169b74235827ea0ef3f8c31dc8/chrome/browser/ui/views/profiles/profile_chooser_view.cc [modify] https://crrev.com/f825aacdf4cbfe169b74235827ea0ef3f8c31dc8/chrome/common/webui_url_constants.cc [modify] https://crrev.com/f825aacdf4cbfe169b74235827ea0ef3f8c31dc8/chrome/common/webui_url_constants.h
,
Jun 15 2018
,
Jun 18 2018
Tried verifying the issue on latest chrome canary 69.0.3464.0 using Mac 10.13.1 and Windows 10 with the below mentioned steps. 1. Launched chrome 2. Chrome://settings -> signed in 3. Clicked on profile card 4. It navigated to chrome://settings/manageProfile Attaching the screencast of the same. Note: Checked on 69.0.3456.0(...assuming this version is without fix), where similar behaviour is seen i.e., it's navigating to chrome://settings/manageProfile. @Thomas Tangl: From the description available in comment#5 it is understood that on clicking profile card, it should navigate to chrome://settings/people. But here in latest canary which is not seen, Could you please let us know if anything missed from our end in the process of verifying the issue.
,
Jun 18 2018
Sorry, the instructions on how to test it are incomplete. Two things: - Set chrome://flags/#account-consistency to "Enabled Dice" - Open the user menu (in the upper right corner) and click the profile card Hope that helps!
,
Jun 19 2018
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #69.0.3464.0 as per the comment #5 & #8. Attaching screen cast for reference. Observed that clicking the profile card in the user menu, is directed to chrome://settings/people. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thakis@chromium.org
, Jun 15 2018