Tracking bug for go/explore-sites-research-prototype This tracks the client side work, requiring a new subsection on the NTP, enabled by the ExploreSites feature flag. This is only implemented on Android.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/577969dd818ce519d4884fbdcfe7a97ea4096438 commit 577969dd818ce519d4884fbdcfe7a97ea4096438 Author: Cathy Li <chili@chromium.org> Date: Tue Jun 12 23:05:01 2018 [Explore Sites] Create resource for new explore sites section on ntp based on flag. Change-Id: I26e290a3c63bee05e83ad269a0234b229c585ca8 Bug: 852075 Reviewed-on: https://chromium-review.googlesource.com/1091226 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#566619} [add] https://crrev.com/577969dd818ce519d4884fbdcfe7a97ea4096438/chrome/android/java/res/layout/explore_sites_section.xml [modify] https://crrev.com/577969dd818ce519d4884fbdcfe7a97ea4096438/chrome/android/java/res/layout/new_tab_page_layout.xml [modify] https://crrev.com/577969dd818ce519d4884fbdcfe7a97ea4096438/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/577969dd818ce519d4884fbdcfe7a97ea4096438/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java [modify] https://crrev.com/577969dd818ce519d4884fbdcfe7a97ea4096438/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSection.java [modify] https://crrev.com/577969dd818ce519d4884fbdcfe7a97ea4096438/chrome/android/java/strings/android_chrome_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21ae462e781e58e0727aaa9613e0979249ae9304 commit 21ae462e781e58e0727aaa9613e0979249ae9304 Author: Cathy Li <chili@chromium.org> Date: Wed Jun 13 07:20:55 2018 [Explore Sites]: Add stub JNI bridge for explore sites. This will later be used to fetch resources for the UI. Bug: 852075 Change-Id: I58fa78a458c9cd329d55d7b4042c15b7f721aa97 Reviewed-on: https://chromium-review.googlesource.com/1095691 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#566744} [add] https://crrev.com/21ae462e781e58e0727aaa9613e0979249ae9304/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java [add] https://crrev.com/21ae462e781e58e0727aaa9613e0979249ae9304/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTile.java [modify] https://crrev.com/21ae462e781e58e0727aaa9613e0979249ae9304/chrome/android/java_sources.gni [modify] https://crrev.com/21ae462e781e58e0727aaa9613e0979249ae9304/chrome/browser/BUILD.gn [add] https://crrev.com/21ae462e781e58e0727aaa9613e0979249ae9304/chrome/browser/android/explore_sites/OWNERS [add] https://crrev.com/21ae462e781e58e0727aaa9613e0979249ae9304/chrome/browser/android/explore_sites/explore_sites_bridge.cc [add] https://crrev.com/21ae462e781e58e0727aaa9613e0979249ae9304/chrome/browser/android/explore_sites/explore_sites_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f21739002cf429db3c6755a92398e2787f5bf442 commit f21739002cf429db3c6755a92398e2787f5bf442 Author: Justin DeWitt <dewittj@chromium.org> Date: Fri Jun 15 16:00:54 2018 [ExploreSites] Adds an explore sites Java owners file. Bug: 852075 Change-Id: Ic0dad63f55974911ae45355d546d1b7ec5efcdc3 Reviewed-on: https://chromium-review.googlesource.com/1101925 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#567669} [add] https://crrev.com/f21739002cf429db3c6755a92398e2787f5bf442/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e9f77a919ab2a14e956ff9b474b01f3492f74b3 commit 3e9f77a919ab2a14e956ff9b474b01f3492f74b3 Author: Cathy Li <chili@chromium.org> Date: Fri Jun 15 18:35:33 2018 [Explore Sites]: Create explore sites tile layout and hook up to json and image loading. Bug: 852075 Change-Id: If09bc4cac1687599bb9009c40248d678f6d16c8b Reviewed-on: https://chromium-review.googlesource.com/1099967 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#567740} [add] https://crrev.com/3e9f77a919ab2a14e956ff9b474b01f3492f74b3/chrome/android/java/res/layout/explore_sites_category_tile_view.xml [modify] https://crrev.com/3e9f77a919ab2a14e956ff9b474b01f3492f74b3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java [add] https://crrev.com/3e9f77a919ab2a14e956ff9b474b01f3492f74b3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTileView.java [add] https://crrev.com/3e9f77a919ab2a14e956ff9b474b01f3492f74b3/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java [modify] https://crrev.com/3e9f77a919ab2a14e956ff9b474b01f3492f74b3/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java [modify] https://crrev.com/3e9f77a919ab2a14e956ff9b474b01f3492f74b3/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/3e9f77a919ab2a14e956ff9b474b01f3492f74b3/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66f0831c883bad092128e4a6e7c574e07e0fc5b7 commit 66f0831c883bad092128e4a6e7c574e07e0fc5b7 Author: Yafei Duan <romax@chromium.org> Date: Tue Jun 19 19:42:13 2018 [ExploreSites] Adds a fetcher for the NTP JSON schema. This doesn't decode the JSON, just grabs it from the appropriate endpoint. The CL was originally uploaded by dewittj@. This CL is fixing the test failure and re-uploading to land since dewittj@ is out of office. Bug: 852075 Change-Id: Ib8adc7cad661665c884a2d058c27c99f40ac0a58 Reviewed-on: https://chromium-review.googlesource.com/1105018 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#568571} [modify] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java [modify] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTile.java [modify] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java [modify] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/browser/BUILD.gn [add] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/browser/android/explore_sites/catalog.cc [add] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/browser/android/explore_sites/catalog.h [modify] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/browser/android/explore_sites/explore_sites_bridge.cc [modify] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/browser/android/explore_sites/explore_sites_bridge.h [add] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/browser/android/explore_sites/ntp_json_fetcher.cc [add] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/browser/android/explore_sites/ntp_json_fetcher.h [add] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/browser/android/explore_sites/ntp_json_fetcher_unittest.cc [modify] https://crrev.com/66f0831c883bad092128e4a6e7c574e07e0fc5b7/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8 commit ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8 Author: Yafei Duan <romax@chromium.org> Date: Tue Jun 19 21:52:27 2018 [Explore Sites] Implementing ExploreSitesBridge::GetIcon. Implements ExploreSitesBridge::GetIcon using ImageFetcher, which takes url and return fetched image via callback. Bug: 852075 Change-Id: I8d3acd770cb2510639cd7896a79a81499874d50d Reviewed-on: https://chromium-review.googlesource.com/1099771 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#568608} [modify] https://crrev.com/ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java [modify] https://crrev.com/ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java [modify] https://crrev.com/ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8/chrome/android/java_sources.gni [add] https://crrev.com/ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8/chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridgeTest.java [add] https://crrev.com/ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8/chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/OWNERS [modify] https://crrev.com/ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8/chrome/browser/android/explore_sites/explore_sites_bridge.cc [modify] https://crrev.com/ac2b767c52f870ac4bc6b3460e11e0b5bf28b9b8/chrome/browser/android/explore_sites/explore_sites_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/448d841f59cb4ddc4429c1fe0a38f2808f413c97 commit 448d841f59cb4ddc4429c1fe0a38f2808f413c97 Author: Cathy Li <chili@chromium.org> Date: Wed Jun 20 00:14:33 2018 [ExploreSites] Add a utility function for finding the catalog URL. This will allow the "more" button to work on the NTP. Bug: 852075 Change-Id: I1a09ddc4f5b4faa484777650bde1eaedce5ec8cd Reviewed-on: https://chromium-review.googlesource.com/1107050 Reviewed-by: Yafei Duan <romax@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#568658} [modify] https://crrev.com/448d841f59cb4ddc4429c1fe0a38f2808f413c97/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java [modify] https://crrev.com/448d841f59cb4ddc4429c1fe0a38f2808f413c97/chrome/browser/BUILD.gn [modify] https://crrev.com/448d841f59cb4ddc4429c1fe0a38f2808f413c97/chrome/browser/android/explore_sites/explore_sites_bridge.cc [modify] https://crrev.com/448d841f59cb4ddc4429c1fe0a38f2808f413c97/chrome/browser/android/explore_sites/explore_sites_bridge.h [add] https://crrev.com/448d841f59cb4ddc4429c1fe0a38f2808f413c97/chrome/browser/android/explore_sites/url_util.cc [add] https://crrev.com/448d841f59cb4ddc4429c1fe0a38f2808f413c97/chrome/browser/android/explore_sites/url_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52a2510d53c5a68612110b4790290242a2d0dc2f commit 52a2510d53c5a68612110b4790290242a2d0dc2f Author: Yafei Duan <romax@chromium.org> Date: Wed Jun 20 23:49:47 2018 [Explore Sites] Fix navigationUrl of tiles. Fix the naviagtionUrl of ExploreSitesCategoryTile by appending the id to the end of GetCatalogUrl(). Bug: 852075 Change-Id: Id1608d7fe379f0788b109dd8dea6c63c5eb8189a Reviewed-on: https://chromium-review.googlesource.com/1108975 Reviewed-by: Cathy Li <chili@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#569089} [modify] https://crrev.com/52a2510d53c5a68612110b4790290242a2d0dc2f/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTile.java [modify] https://crrev.com/52a2510d53c5a68612110b4790290242a2d0dc2f/chrome/browser/android/explore_sites/ntp_json_fetcher.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39718f1f0040c56af72fece3e925b1c19611221d commit 39718f1f0040c56af72fece3e925b1c19611221d Author: Cathy Li <chili@chromium.org> Date: Thu Jun 21 00:49:28 2018 [Explore sites]: Make explore category tiles pretty Bug: 852075 Change-Id: Ieb6329d57005bdba63cdf7ed1f991b5da61bb362 Reviewed-on: https://chromium-review.googlesource.com/1103138 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#569109} [modify] https://crrev.com/39718f1f0040c56af72fece3e925b1c19611221d/chrome/android/java/res/layout/explore_sites_category_tile_view.xml [modify] https://crrev.com/39718f1f0040c56af72fece3e925b1c19611221d/chrome/android/java/res/layout/explore_sites_section.xml [modify] https://crrev.com/39718f1f0040c56af72fece3e925b1c19611221d/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/39718f1f0040c56af72fece3e925b1c19611221d/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryTileView.java [modify] https://crrev.com/39718f1f0040c56af72fece3e925b1c19611221d/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b39bd8924173bd52fa62405efd47e6ba01aaf796 commit b39bd8924173bd52fa62405efd47e6ba01aaf796 Author: Cathy Li <chili@chromium.org> Date: Mon Jun 25 04:44:07 2018 [Explore sites]: fix margins and add border to "more categories" button. Bug: 852075 Change-Id: Ibdd7001d62b9adc0f3d2c74b12f77e904cf27d06 Reviewed-on: https://chromium-review.googlesource.com/1112706 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#569966} [add] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/chrome/android/java/res/drawable/button_white_border.xml [modify] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/chrome/android/java/res/layout/explore_sites_category_tile_view.xml [modify] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/chrome/android/java/res/layout/explore_sites_section.xml [modify] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/chrome/android/java/res/values-v21/styles.xml [modify] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/b39bd8924173bd52fa62405efd47e6ba01aaf796/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/059d76f6ac346fd4a05c526a665f356d1306f99c commit 059d76f6ac346fd4a05c526a665f356d1306f99c Author: Cathy Li <chili@chromium.org> Date: Mon Jun 25 22:29:28 2018 [Explore sites]: rename the button background style. This is to make it clear that it is its own snowflake and should be fixed later. Bug: 852075 Change-Id: I30991e144e6e39b433757a7aaa3749a6bb20c85a Reviewed-on: https://chromium-review.googlesource.com/1113619 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#570205} [rename] https://crrev.com/059d76f6ac346fd4a05c526a665f356d1306f99c/chrome/android/java/res/drawable/explore_sites_button_background.xml [modify] https://crrev.com/059d76f6ac346fd4a05c526a665f356d1306f99c/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/059d76f6ac346fd4a05c526a665f356d1306f99c/chrome/android/java/res/values-v21/styles.xml
Comment 1 by bugdroid1@chromium.org
, Jun 12 2018