Issue 852074 link

Starred by 2 users

Issue metadata

Status:	WontFix
Owner:	twelling...@chromium.org
Closed:	Oct 18
Cc:	bsazonov@chromium.org █ bauerb@chromium.org █ ramyan@chromium.org
Components:	Services>SignIn Tests>Flaky UI>Browser>NewTabPage
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
Via-TryFlakes zine-triaged

"org.chromium.chrome.browser.ntp.NewTabPageTest#testThumbnailInvalidations" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 12 2018

Issue description

"org.chromium.chrome.browser.ntp.NewTabPageTest#testThumbnailInvalidations" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVAsSBUZsYWtlIklvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIubnRwLk5ld1RhYlBhZ2VUZXN0I3Rlc3RUaHVtYm5haWxJbnZhbGlkYXRpb25zDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by dpranke@chromium.org, Jun 15 2018

Labels: Pri-2

Comment 2 by treib@chromium.org, Jun 18 2018

Example failure log:

I  384.462s run_tests_on_device(01e2c6fd0b69c033)  detected failure in org.chromium.chrome.browser.ntp.NewTabPageTest#testThumbnailInvalidations. raw output:
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: numtests=1
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: stream=
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    org.chromium.chrome.browser.ntp.NewTabPageTest:
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: test=testThumbnailInvalidations
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.ntp.NewTabPageTest
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: current=1
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS_CODE: 1
I  384.462s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: numtests=1
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: stream=.
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: test=testThumbnailInvalidations
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.ntp.NewTabPageTest
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: current=1
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS_CODE: 0
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: numtests=1
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    INSTRUMENTATION_STATUS: stream=
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    Process crashed while executing testThumbnailInvalidations(org.chromium.chrome.browser.ntp.NewTabPageTest):
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    java.lang.AssertionError: detach() should be called before setting up a new view
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.signin.SigninPromoController.setupPromoView(SigninPromoController.java:209)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.ntp.cards.SignInPromo$PersonalizedPromoViewHolder.bindPersonalizedSigninPromo(SignInPromo.java:344)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.ntp.cards.SignInPromo$PersonalizedPromoViewHolder.onBindViewHolder(SignInPromo.java:305)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.ntp.cards.SignInPromo.onBindViewHolder(SignInPromo.java:150)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.ntp.cards.OptionalLeaf.onBindViewHolder(OptionalLeaf.java:39)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.ntp.cards.InnerNode.onBindViewHolder(InnerNode.java:77)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter.onBindViewHolder(NewTabPageAdapter.java:155)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter.onBindViewHolder(NewTabPageAdapter.java:42)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:6541)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:5484)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:5750)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:5589)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:5585)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2231)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1558)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1518)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:620)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:3719)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3436)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3988)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.suggestions.SuggestionsRecyclerView.onLayout(SuggestionsRecyclerView.java:205)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at org.chromium.chrome.browser.compositor.CompositorViewHolder.onLayout(CompositorViewHolder.java:804)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.463s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.design.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1171)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.design.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:856)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.support.design.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:875)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1743)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1586)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.LinearLayout.onLayout(LinearLayout.java:1495)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:336)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.widget.FrameLayout.onLayout(FrameLayout.java:273)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at com.android.internal.policy.PhoneWindow$DecorView.onLayout(PhoneWindow.java:2678)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.View.layout(View.java:16636)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewGroup.layout(ViewGroup.java:5437)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2171)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1931)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1107)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6013)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:858)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.Choreographer.doCallbacks(Choreographer.java:670)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.Choreographer.doFrame(Choreographer.java:606)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.os.Handler.handleCallback(Handler.java:739)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.os.Handler.dispatchMessage(Handler.java:95)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.os.Looper.loop(Looper.java:148)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at android.app.ActivityThread.main(ActivityThread.java:5417)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at java.lang.reflect.Method.invoke(Method.java)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
I  384.464s run_tests_on_device(01e2c6fd0b69c033)    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Comment 3 by treib@chromium.org, Jun 18 2018

Components: UI>Browser>NewTabPage
Labels: OS-Android

Comment 4 by treib@chromium.org, Jun 18 2018

Seems to be flaky on the tryserver but not on the waterfall:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.ntp.NewTabPageTest%23testThumbnailInvalidations

Comment 5 by treib@chromium.org, Jun 18 2018

Labels: -Sheriff-Chromium
Owner: twelling...@chromium.org
Status: Assigned (was: Untriaged)

Since it's not that common, taking out of the sheriff queue for now.
Over to twellington who's worked in that area to either investigate or triage further.

Comment 6 by twelling...@chromium.org, Jun 18 2018

Cc: bauerb@chromium.org

Try flakes has reported flakes back to November 2017, so it appears that this is a long standing issue.

+bauerb@ - do you recall seeing an issue like this with other tests? I have a faint memory that this is something we've possibly run into before.

Comment 7 by bau...@google.com, Jun 18 2018

Cc: bsazonov@chromium.org
Components: Services>SignIn

I haven't seen a flakiness issue with this, in particular with RecyclerView. Either we are failing to detach the ViewHolder from the RecyclerView, or RecyclerView is failing to notify us, which would be… a bit scary.

Comment 8 by twelling...@chromium.org, Jun 19 2018

Labels: zine-triaged

P1 to disable, P2 to investigate

Comment 9 by twelling...@chromium.org, Jun 25 2018

I've been trying to get a repro with some logging here to no avail: https://chromium-review.googlesource.com/c/chromium/src/+/1108194

It appears that this flaked a few times in a row on 06/11 and 06/12, but otherwise hasn't been flaking too much.

Project Member

Comment 10 by sheriffbot@chromium.org, Jul 26

Status: Available (was: Assigned)

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by benhenry@chromium.org, Aug 2

Status: Assigned (was: Available)

Project Member

Comment 12 by sheriffbot@chromium.org, Sep 3

Status: Available (was: Assigned)

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by twelling...@chromium.org, Oct 18

Status: WontFix (was: Available)

This hasn't shown any recent flakes. Closing as WontFix.

►

Issue 852074 link

Issue metadata

"org.chromium.chrome.browser.ntp.NewTabPageTest#testThumbnailInvalidations" is flaky

Issue description

Comment 1 by dpranke@chromium.org, Jun 15 2018

Comment 1 Deleted

Comment 2 by treib@chromium.org, Jun 18 2018

Comment 2 Deleted

Comment 3 by treib@chromium.org, Jun 18 2018

Comment 3 Deleted

Comment 4 by treib@chromium.org, Jun 18 2018

Comment 4 Deleted

Comment 5 by treib@chromium.org, Jun 18 2018

Comment 5 Deleted

Comment 6 by twelling...@chromium.org, Jun 18 2018

Comment 6 Deleted

Comment 7 by bau...@google.com, Jun 18 2018

Comment 7 Deleted

Comment 8 by twelling...@chromium.org, Jun 19 2018

Comment 8 Deleted

Comment 9 by twelling...@chromium.org, Jun 25 2018

Comment 9 Deleted

Comment 10 by sheriffbot@chromium.org, Jul 26

Comment 10 Deleted

Comment 11 by benhenry@chromium.org, Aug 2

Comment 11 Deleted

Comment 12 by sheriffbot@chromium.org, Sep 3

Comment 12 Deleted

Comment 13 by twelling...@chromium.org, Oct 18

Comment 13 Deleted

Sign in to add a comment