Latest MacOSX failures seem related to hotkeys and started failing one build after https://chromium-review.googlesource.com/c/chromium/src/+/1096082

Assigning erikchen@ to investigate further.

My CL was in the last batch to pass the tests. It looks like this test started failing on all macOS versions after this CL

"Revert "variations: add client config for ViewsBrowserWindows""

First failing batch on 10.13: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/3451
10.10: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33054
10.12: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13714

My guess is that I added a test which only works with that variation, and when it was removed, everything started failing?

Erik, thanks for the driving this investigation.

Fix up: https://chromium-review.googlesource.com/c/chromium/src/+/1097847

This was in fact caused by the change I pointed out in c#2: 
https://chromium-review.googlesource.com/c/chromium/src/+/1096376

See Find-it note: https://chromium-review.googlesource.com/c/chromium/src/+/1096376#message-9597bafdeb4f47e40fc10116fa3b1d1762aae301

 Issue 852172  has been merged into this issue.

keywords
GlobalKeyboardShortcutsTest.SwitchTabsMac
GlobalKeyboardShortcutsTest.CopyPasteOmnibox

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b706d155364443773d28a16d7ae35914ca44e982

commit b706d155364443773d28a16d7ae35914ca44e982
Author: erikchen <erikchen@chromium.org>
Date: Tue Jun 12 23:21:22 2018

Fix GlobalKeyboardShortcutsTest on Cocoa.

The tests were added when interactive_ui_tests were only being run on Views
code. Subsequently, when interactive_ui_tests was switched to Cocoa code, the
tests failed.

There were two test bugs:
* In Cocoa, using Cmd+2 to select the second tab is asynchronous, but the test
  was not waiting.
* The test was dispatching events by sending them directly to the NSWindow. This
  is incorrect - the events should be sent to NSApp.

Bug:  852064 
Change-Id: I4cf73724954a90edcfe4dd5a0f4a56fcd13df4a2
Reviewed-on: https://chromium-review.googlesource.com/1097847
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566628}
[modify] https://crrev.com/b706d155364443773d28a16d7ae35914ca44e982/chrome/browser/global_keyboard_shortcuts_mac_browsertest.mm

Just FYI,

"Mac10.11 Tests" build #27298 passed with green, but the next builds since #27298 started failing again on browser_tests.

#c8 seems having fixed interactive_ui_tests GlobalKeyboardShortcutsTest.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/27297

The list of failing browser_tests is very different now though, I'd guess that's a new and different bug.

over to elly.

Resolving this bug. Erik has chased down the GlobalKeyboardShortcutsTest issue.

Will open a new bug for the new failures.