New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852056 link

Starred by 2 users
Status: Fixed
Owner:
aee@chromium.org
Closed: Jul 4
Cc:
█ scottchen@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

WebUI: button style not updated in password-dialog from CrOS zip-archiver

Project Member Reported by scottchen@chromium.org, Jun 12 2018 
1) Download the encrypted zip on CrOS
2) Go to Files app, double-click on the zip
3) double-click the txt within the zip
4) observe a password prompt dialog appear.

Button styles are not md-refreshed
Screen Shot 2018-06-11 at 7.19.53 PM.png
21.3 KB View Download

Comment 1 by weifangsun@chromium.org, Jun 15 2018

Components: Platform>Apps>FileManager

Comment 2 by aee@chromium.org, Jul 2

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Assigned (was: Available)

Comment 3 by aee@chromium.org, Jul 2 

Screenshot for https://chromium-review.googlesource.com/c/chromium/src/+/1123403
passphrase_dialog_button_style_refresh.png
8.4 KB View Download

Comment 4 by aee@chromium.org, Jul 2

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df57de1f1f6295e4159359765a2b0247a03a05e1

commit df57de1f1f6295e4159359765a2b0247a03a05e1
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Jul 04 05:31:23 2018

WebUI: apply button style refresh to the passphrase dialog

Bug:  852056 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7c8bde3aa2b5fc77daf1b022f85cbecffa5915ce
Reviewed-on: https://chromium-review.googlesource.com/1123403
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572486}
[modify] https://crrev.com/df57de1f1f6295e4159359765a2b0247a03a05e1/chrome/browser/resources/chromeos/zip_archiver/BUILD.gn
[delete] https://crrev.com/7894bc2d9a514165e2a24deedde5c397575832a8/chrome/browser/resources/chromeos/zip_archiver/css/passphrase-dialog.css
[modify] https://crrev.com/df57de1f1f6295e4159359765a2b0247a03a05e1/chrome/browser/resources/chromeos/zip_archiver/html/passphrase-dialog.html

Comment 6 by aee@chromium.org, Jul 4

Status: Fixed (was: Started)
►

Sign in to add a comment