New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852055 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 852246
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

"RestorePrefs/FilesAppBrowserTest.Test/restoreSortColumn" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 12 2018

Issue description

"RestorePrefs/FilesAppBrowserTest.Test/restoreSortColumn" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQgsSBUZsYWtlIjdSZXN0b3JlUHJlZnMvRmlsZXNBcHBCcm93c2VyVGVzdC5UZXN0L3Jlc3RvcmVTb3J0Q29sdW1uDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: Pri-2

Comment 2 by treib@chromium.org, Jun 18 2018

Components: Platform>Apps>FileManager
Labels: -Sheriff-Chromium
Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=RestorePrefs/FilesAppBrowserTest.Test/restoreSortColumn

There were a few failures on 06-12 and 06-13, but it seems they haven't occurred again. There are some timeouts after 60s on "Linux Chromium OS ASan LSan Tests (1)", but since the test regularly takes 50s to run on that bot, that's not surprising.

Assigning to an owner to take a look, but this might just be WontFix.

Comment 3 by treib@chromium.org, Jun 18 2018

Labels: OS-Chrome

Comment 4 by noel@chromium.org, Jun 19 2018

Cc: treib@chromium.org kbr@chromium.org fukino@chromium.org dpranke@chromium.org
Owner: noel@chromium.org
This is  issue 852246 , looking at the log in the OP ...

[19088:19088:0612/114551.273745:INFO:CONSOLE(0)] "[FAIL] [restoreSortColumn]: TypeError: Cannot read property 'length' of undefined


> There were a few failures on 06-12 and 06-13, but it seems they haven't occurred again.

Yes, bad v8 roll, was fixed pronto and the flakes stopped.

> There are some timeouts after 60s on "Linux Chromium OS ASan LSan Tests (1)", but since the test regularly takes 50s to run on that bot, that's not surprising.

These tests shard to 4 on the bots => 4 instances of ChromeOS running per bot, and then they each load ChromeOS Files.App and bang on the disk and contend.

That increases the chance that a Files.App browser test times-out with the bot under load this way. 

  Avg test run-itme 50s, variation in run-time +- 20%

That 20% seems very high to me, but causes these tests to often hit the bot time-out.  The test is then re-run on its own (because it failed and there are no other tests to run), and always pass.  TIMEOUT-PASS, TIMEOUT-PASS ...

Seems to me the bot time-out scaling for MSAN/ASAN on ChromeOS bots is not quite right.  +dpranke +kbr to see if there is anything we could do about that.

Comment 5 by noel@chromium.org, Jun 19 2018

Mergedinto: 852246
Status: Duplicate (was: Assigned)

Sign in to add a comment