New issue
Advanced search Search tips

Issue 852053 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

LayoutTests should support serving via PHP not just in http/tests

Project Member Reported by npm@chromium.org, Jun 12 2018

Issue description

I wanted to serve a delayed resource in a test in performance/event-timing and only realized after lots of time that this is not supported in that folder. But it worked fine when moving the test to http/tests. I see no reason for this discrepancy, but if there is a reason then the fact that this directory is special should be more obvious.
 

Comment 1 by npm@chromium.org, Jun 12 2018

Components: Blink>Infra

Comment 2 by zcorpan@gmail.com, Jun 16 2018

Can you use wptserve's trickle feature (or a .py handler if you need more control)?

https://wptserve.readthedocs.io/en/latest/pipes.html#trickle

Not sure whether this is available outside external/wpt.

Comment 3 by npm@chromium.org, Jun 18 2018

Yea I mean for tests outside of external/wpt and http/tests. I don't think any of those options work either.
wptserve features can be available outside external/wpt -- we would just need to whitelist another directory besides external/wpt in Port.should_use_wptserve (https://cs.chromium.org/chromium/src/third_party/blink/tools/blinkpy/web_tests/port/base.py?l=1235).

It has been a goal for a long time to remove dependence on apache and PHP entirely and just switch to wptserve (https://crbug.com/347864) -- this would simplify the test runner and the test suite, and maybe make it easier to contribute some tests to wpt, so using wptserve instead of PHP would be preferable.

Comment 5 by npm@chromium.org, Jun 18 2018

I feel like I've asked before if we could have wptserve outside external/wpt... If it could work right away, we should definitely start doing that :) maybe we can create a file that contains the wptserved folder names, and start encouraging people to add folders.
Thanks for filing the issue, npm@! And thanks for the context, qyearsley@.

Yup, it was on my radar earlier this year and I did some preliminary research. Basically, migrating all existing PHP tests is a bit too much of work without significant benefits, and creating another directory with wptserve enabled seems like a better option. Yet I forgot to file an issue back then, sorry. Just filed issue 853815.

As mentioned in #4, for the most part it should be pretty simple. A major complication is the manifest support. In WPT, we can have `.any.js` that would turn into various tests (window, workers, etc.), so the test names are no longer just file names. It's probably not very important so we may simply drop these features in that directory.

Comment 7 by npm@chromium.org, Jun 18 2018

Thanks, Robert! At least in my personal experience, it's very worth it to have this new directory, even without the features that depend on manifest support.
Components: Blink>Infra>Ecosystem
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)

Sign in to add a comment