New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852049 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 828996



Sign in to add a comment

Network - OOBE Update

Project Member Reported by zalcorn@chromium.org, Jun 12 2018

Issue description

Tracking updates to Network OOBE screen, including:

- List spacing
- Color of dividing lines, icon, and text
- Footer dividing line only shows when network list is scrollable
- Text field component update
- All template changes in crbug/852034

Full spec at https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZcWxQVKsUFtK/files/MCGJEufWNx2OfjgHkPICAWyNwMSJbxAVNpw

 
Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad99c323336b00fc3677cdf3da3d38085e24329b

commit ad99c323336b00fc3677cdf3da3d38085e24329b
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Aug 15 04:10:32 2018

Chrome OS OOBE: add floating bottom-border to the network selection.

Bottom-botder was disabled (because it conflicted with another line).
This Cl returns it back.

Bug:  852049 
Change-Id: I2bd0d2282114809f19e85bced6f821b1b8379aa7
Reviewed-on: https://chromium-review.googlesource.com/1171954
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583160}
[modify] https://crrev.com/ad99c323336b00fc3677cdf3da3d38085e24329b/chrome/browser/resources/chromeos/login/oobe_network.html

Labels: Merge-Request-69
Status: Fix (was: Started)
Status: Fixed (was: Fix)
Labels: -Merge-Request-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875fd3b463da4092838d7ce6d82d05b55e6af45b

commit 875fd3b463da4092838d7ce6d82d05b55e6af45b
Author: Alexander Alekseev <alemate@google.com>
Date: Wed Aug 15 19:14:17 2018

Chrome OS OOBE: add floating bottom-border to the network selection.

Bottom-botder was disabled (because it conflicted with another line).
This Cl returns it back.

TBR=stevenjb@chromium.org

(cherry picked from commit ad99c323336b00fc3677cdf3da3d38085e24329b)

Bug:  852049 
Change-Id: I2bd0d2282114809f19e85bced6f821b1b8379aa7
Reviewed-on: https://chromium-review.googlesource.com/1171954
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583160}
Reviewed-on: https://chromium-review.googlesource.com/1176228
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#656}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/875fd3b463da4092838d7ce6d82d05b55e6af45b/chrome/browser/resources/chromeos/login/oobe_network_dialog.html

Sign in to add a comment