New issue
Advanced search Search tips

Issue 852048 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

SkPaintImageFilter rect transformed into nan asserts

Project Member Reported by ClusterFuzz, Jun 12 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6613954194046976

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x053900002641
Crash State:
  sk_abort_no_print
  SkCanvas::onDrawRect
  SkCanvas::onDrawRect
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=559994:560034

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6613954194046976

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 12 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 12 2018

Cc: enne@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.

Comment 3 by enne@chromium.org, Jun 12 2018

Owner: enne@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by enne@chromium.org, Jun 19 2018

Summary: SkPaintImageFilter rect transformed into nan asserts (was: Abrt in sk_abort_no_print)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/721e63727f38b9c7664a173ab475d7c7a58cd8a8

commit 721e63727f38b9c7664a173ab475d7c7a58cd8a8
Author: Adrienne Walker <enne@chromium.org>
Date: Mon Jun 25 17:52:55 2018

Validate transformed SkPaintImageFilter rects

These can be transformed into invalid rects, so don't try to draw them.

Bug: chromium: 852048
Change-Id: I95a8b86557e550453efb0896f6d559a843f47d2a
Reviewed-on: https://skia-review.googlesource.com/135924
Commit-Queue: Adrienne Walker <enne@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/721e63727f38b9c7664a173ab475d7c7a58cd8a8/src/effects/imagefilters/SkPaintImageFilter.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96722ce99416f1e4ffd0a4bd8c043000ce76b69f

commit 96722ce99416f1e4ffd0a4bd8c043000ce76b69f
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jun 25 20:50:33 2018

Roll src/third_party/skia ed55419d859b..ff168d9258e0 (4 commits)

https://skia.googlesource.com/skia.git/+log/ed55419d859b..ff168d9258e0


git log ed55419d859b..ff168d9258e0 --date=short --no-merges --format='%ad %ae %s'
2018-06-25 bsalomon@google.com Put GrPrimitiveProcessor/GrGeometryProcessor before GrPipeline in param lists.
2018-06-25 enne@chromium.org Validate transformed SkPaintImageFilter rects
2018-06-25 hcm@google.com update externally published milestone schedule
2018-06-25 reed@google.com remove bad assert


Created with:
  gclient setdep -r src/third_party/skia@ff168d9258e0

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium: 852048,chromium:855854
TBR=jcgregorio@chromium.org

Change-Id: I66cbf0f9efc9793ac60c1d969b4ad7207eea857e
Reviewed-on: https://chromium-review.googlesource.com/1113825
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570170}
[modify] https://crrev.com/96722ce99416f1e4ffd0a4bd8c043000ce76b69f/DEPS

Project Member

Comment 7 by ClusterFuzz, Jun 26 2018

ClusterFuzz has detected this issue as fixed in range 570153:570175.

Detailed report: https://clusterfuzz.com/testcase?key=6613954194046976

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x053900002641
Crash State:
  sk_abort_no_print
  SkCanvas::onDrawRect
  SkCanvas::onDrawRect
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=559994:560034
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=570153:570175

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6613954194046976

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jun 26 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6613954194046976 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment