Tracking updates to OOBE Welcome screen, including: - New animation (.mp4) - All GM2 template updates (crbug/852034) Full spec: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZcWxQVKsUFtK/files/MCGJEufWNx2OfnjxBt3TZhD3wMSJbxAVNpw
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ui-webui-internal/+/4afc450a9363ab44f45c3639d0661daa7dbe5bda commit 4afc450a9363ab44f45c3639d0661daa7dbe5bda Author: Alexander Alekseev <alemate@google.com> Date: Thu Jul 19 22:23:27 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/efcbbd5122e2bfcdadf33c01ff34cd5eb1d47ec3 commit efcbbd5122e2bfcdadf33c01ff34cd5eb1d47ec3 Author: Alexander Alekseev <alemate@google.com> Date: Fri Jul 20 01:56:53 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03020af859eba312d0e79d0e1241548dc3523f79 commit 03020af859eba312d0e79d0e1241548dc3523f79 Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jul 20 03:23:23 2018 Roll src-internal ea9328b8e855..9cf0f36d349f (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea9328b8e855..9cf0f36d349f Created with: gclient setdep -r src-internal@9cf0f36d349f The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:852038 , chromium:852034 TBR=mmoss@chromium.org Change-Id: I07282894134f4ba5d4aa6f4888c92d79871a1a1f Reviewed-on: https://chromium-review.googlesource.com/1144283 Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576768} [modify] https://crrev.com/03020af859eba312d0e79d0e1241548dc3523f79/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afa32f3e6933cfa8bb93af265d77f5d4e0cda9e5 commit afa32f3e6933cfa8bb93af265d77f5d4e0cda9e5 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Jul 25 21:58:36 2018 Grit: Fix bug with generating dependency on hidden files. Grit previously ignored <if> conditions when generating dependency file. This CL makes Grit to include into dependency only files that were actually included in the output. Bug: 866232 , 852038 Change-Id: I8d974219d00a76568263d7ecf8eab811807565b4 Reviewed-on: https://chromium-review.googlesource.com/1149145 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#578086} [modify] https://crrev.com/afa32f3e6933cfa8bb93af265d77f5d4e0cda9e5/tools/grit/grit/format/html_inline.py [modify] https://crrev.com/afa32f3e6933cfa8bb93af265d77f5d4e0cda9e5/tools/grit/grit/format/html_inline_unittest.py [modify] https://crrev.com/afa32f3e6933cfa8bb93af265d77f5d4e0cda9e5/tools/grit/grit/gather/chrome_html.py [modify] https://crrev.com/afa32f3e6933cfa8bb93af265d77f5d4e0cda9e5/tools/grit/grit/node/include.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88695c64b41b51f02e484b0b7bee3db356eab9fb commit 88695c64b41b51f02e484b0b7bee3db356eab9fb Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Jul 27 00:45:57 2018 Grit: Fix bug with generating dependency on hidden files. Grit previously ignored <if> conditions when generating dependency file. This CL makes Grit to include into dependency only files that were actually included in the output. TBR=alemate@chromium.org (cherry picked from commit afa32f3e6933cfa8bb93af265d77f5d4e0cda9e5) Bug: 866232 , 852038 Change-Id: I8d974219d00a76568263d7ecf8eab811807565b4 Reviewed-on: https://chromium-review.googlesource.com/1149145 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578086} Reviewed-on: https://chromium-review.googlesource.com/1152523 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#136} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/88695c64b41b51f02e484b0b7bee3db356eab9fb/tools/grit/grit/format/html_inline.py [modify] https://crrev.com/88695c64b41b51f02e484b0b7bee3db356eab9fb/tools/grit/grit/format/html_inline_unittest.py [modify] https://crrev.com/88695c64b41b51f02e484b0b7bee3db356eab9fb/tools/grit/grit/gather/chrome_html.py [modify] https://crrev.com/88695c64b41b51f02e484b0b7bee3db356eab9fb/tools/grit/grit/node/include.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/browser_internal/+/78467a7508b0428cfb1c4d6300d161d084d679c8 commit 78467a7508b0428cfb1c4d6300d161d084d679c8 Author: Alexander Alekseev <alemate@google.com> Date: Fri Jul 27 01:43:47 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/1d201c0289f2392b6f7cb998248e1753361b2f11 commit 1d201c0289f2392b6f7cb998248e1753361b2f11 Author: Alexander Alekseev <alemate@google.com> Date: Fri Jul 27 01:49:24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49ccfa3a5bb70a21d4cbb9b215a9563b219f9d65 commit 49ccfa3a5bb70a21d4cbb9b215a9563b219f9d65 Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jul 27 03:20:32 2018 Roll src-internal e83d89c060cd..1d201c0289f2 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e83d89c060cd..1d201c0289f2 Created with: gclient setdep -r src-internal@1d201c0289f2 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:852038 TBR=mmoss@chromium.org Change-Id: Ibbf899b982866bb65858f197a284d1afcb8e1e85 Reviewed-on: https://chromium-review.googlesource.com/1152272 Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578528} [modify] https://crrev.com/49ccfa3a5bb70a21d4cbb9b215a9563b219f9d65/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/903b12a4b2cf8b279daa426071d736ec15902cf1 commit 903b12a4b2cf8b279daa426071d736ec15902cf1 Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Jul 28 01:03:55 2018 ChromeOS OOBE: Add Welcome screen animations. This Cl replaces static images with animations. Bug: 852038 Change-Id: Id58f69e4275231dc4b6491358d10a343f529fc2f Reviewed-on: https://chromium-review.googlesource.com/1153832 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578882} [delete] https://crrev.com/91b578ae94ff621656cbf79eb42d7c24f69a6a9a/chrome/browser/resources/chromeos/login/images/welcome_illustration_1x.png [delete] https://crrev.com/91b578ae94ff621656cbf79eb42d7c24f69a6a9a/chrome/browser/resources/chromeos/login/images/welcome_illustration_2x.png [delete] https://crrev.com/91b578ae94ff621656cbf79eb42d7c24f69a6a9a/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_1x.png [delete] https://crrev.com/91b578ae94ff621656cbf79eb42d7c24f69a6a9a/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_2x.png [delete] https://crrev.com/91b578ae94ff621656cbf79eb42d7c24f69a6a9a/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_1x.png [delete] https://crrev.com/91b578ae94ff621656cbf79eb42d7c24f69a6a9a/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_2x.png [modify] https://crrev.com/903b12a4b2cf8b279daa426071d736ec15902cf1/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/903b12a4b2cf8b279daa426071d736ec15902cf1/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html [modify] https://crrev.com/903b12a4b2cf8b279daa426071d736ec15902cf1/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc2286bf2dae987b6d4764a62b0deb4991bc28e0 commit fc2286bf2dae987b6d4764a62b0deb4991bc28e0 Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Jul 31 05:32:22 2018 Revert "ChromeOS OOBE: Add Welcome screen animations." This reverts commit 903b12a4b2cf8b279daa426071d736ec15902cf1. Reason for revert: https://crbug.com/869189 . Original change's description: > ChromeOS OOBE: Add Welcome screen animations. > > This Cl replaces static images with animations. > > Bug: 852038 > Change-Id: Id58f69e4275231dc4b6491358d10a343f529fc2f > Reviewed-on: https://chromium-review.googlesource.com/1153832 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578882} TBR=alemate@chromium.org,wzang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852038 ,869189 Change-Id: Icb34fb1b55268e0779e14deac01245397906c567 Reviewed-on: https://chromium-review.googlesource.com/1155503 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#579319} [add] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/images/welcome_illustration_1x.png [add] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/images/welcome_illustration_2x.png [add] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_1x.png [add] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_2x.png [add] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_1x.png [add] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_2x.png [modify] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html [modify] https://crrev.com/fc2286bf2dae987b6d4764a62b0deb4991bc28e0/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/529b568b5e37551f677a135c6ac34ef78b2e5569 commit 529b568b5e37551f677a135c6ac34ef78b2e5569 Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Jul 31 22:08:55 2018 Revert "ChromeOS OOBE: Add Welcome screen animations." This reverts commit 903b12a4b2cf8b279daa426071d736ec15902cf1. Reason for revert: https://crbug.com/869189 . Original change's description: > ChromeOS OOBE: Add Welcome screen animations. > > This Cl replaces static images with animations. > > Bug: 852038 > Change-Id: Id58f69e4275231dc4b6491358d10a343f529fc2f > Reviewed-on: https://chromium-review.googlesource.com/1153832 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578882} TBR=alemate@chromium.org, wzang@chromium.org (cherry picked from commit fc2286bf2dae987b6d4764a62b0deb4991bc28e0) Bug: 852038 ,869189 Change-Id: Icb34fb1b55268e0779e14deac01245397906c567 Reviewed-on: https://chromium-review.googlesource.com/1155503 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579319} Reviewed-on: https://chromium-review.googlesource.com/1157298 Cr-Commit-Position: refs/branch-heads/3508@{#3} Cr-Branched-From: c8a012d0f823483d9d974ed01652b0c84519fbbb-refs/heads/master@{#579241} [add] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/images/welcome_illustration_1x.png [add] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/images/welcome_illustration_2x.png [add] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_1x.png [add] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_2x.png [add] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_1x.png [add] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_2x.png [modify] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html [modify] https://crrev.com/529b568b5e37551f677a135c6ac34ef78b2e5569/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/browser_internal/+/ba2b652a19399f4d07ef562668a50fb24bd568c1 commit ba2b652a19399f4d07ef562668a50fb24bd568c1 Author: Alexander Alekseev <alemate@google.com> Date: Mon Aug 06 22:01:04 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/3cd5de0de3a14991f1133ff77e280b7faa688ea3 commit 3cd5de0de3a14991f1133ff77e280b7faa688ea3 Author: Alexander Alekseev <alemate@google.com> Date: Mon Aug 06 22:05:33 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7f7ba5889e2c815d4cde5714d960a05f2b3f6ce commit d7f7ba5889e2c815d4cde5714d960a05f2b3f6ce Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Aug 07 00:46:48 2018 Roll src-internal ca942e227a7a..3cd5de0de3a1 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca942e227a7a..3cd5de0de3a1 Created with: gclient setdep -r src-internal@3cd5de0de3a1 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:852038 TBR=mmoss@chromium.org Change-Id: I9d7ee59a61de8382b0a2537f675b1cc4136df3a6 Reviewed-on: https://chromium-review.googlesource.com/1164283 Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581070} [modify] https://crrev.com/d7f7ba5889e2c815d4cde5714d960a05f2b3f6ce/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04b716f7608bea53d0903f821ef0aa4f59741b6d commit 04b716f7608bea53d0903f821ef0aa4f59741b6d Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Aug 09 00:32:39 2018 ChromeOS OOBE: Add Welcome screen animations. This Cl replaces static images with animations. Bug: 852038 Change-Id: I8185420aed0ed23c080ac0bc7a2270d3ac4c5b7b Reviewed-on: https://chromium-review.googlesource.com/1166590 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581735} [delete] https://crrev.com/b3d44f8bee4cc8358dcd3c6bcb168edeee488607/chrome/browser/resources/chromeos/login/images/welcome_illustration_1x.png [delete] https://crrev.com/b3d44f8bee4cc8358dcd3c6bcb168edeee488607/chrome/browser/resources/chromeos/login/images/welcome_illustration_2x.png [delete] https://crrev.com/b3d44f8bee4cc8358dcd3c6bcb168edeee488607/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_1x.png [delete] https://crrev.com/b3d44f8bee4cc8358dcd3c6bcb168edeee488607/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_2x.png [delete] https://crrev.com/b3d44f8bee4cc8358dcd3c6bcb168edeee488607/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_1x.png [delete] https://crrev.com/b3d44f8bee4cc8358dcd3c6bcb168edeee488607/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_2x.png [modify] https://crrev.com/04b716f7608bea53d0903f821ef0aa4f59741b6d/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/04b716f7608bea53d0903f821ef0aa4f59741b6d/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html [modify] https://crrev.com/04b716f7608bea53d0903f821ef0aa4f59741b6d/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7 commit fe05e5716dc917fb74ae720a0bd6f1a4faf885e7 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Aug 09 01:51:26 2018 Revert "ChromeOS OOBE: Add Welcome screen animations." This reverts commit 04b716f7608bea53d0903f821ef0aa4f59741b6d. Reason for revert: Broke build. Original change's description: > ChromeOS OOBE: Add Welcome screen animations. > > This Cl replaces static images with animations. > > Bug: 852038 > Change-Id: I8185420aed0ed23c080ac0bc7a2270d3ac4c5b7b > Reviewed-on: https://chromium-review.googlesource.com/1166590 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581735} TBR=alemate@chromium.org,wzang@chromium.org Change-Id: Ife8153c5136c12b3973f44cb231c40d897188343 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 852038 Reviewed-on: https://chromium-review.googlesource.com/1168325 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#581737} [add] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/images/welcome_illustration_1x.png [add] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/images/welcome_illustration_2x.png [add] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_1x.png [add] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_2x.png [add] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_1x.png [add] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_2x.png [modify] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html [modify] https://crrev.com/fe05e5716dc917fb74ae720a0bd6f1a4faf885e7/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90fc78b7221e1b13470e34ff01efb8d22bfc0c79 commit 90fc78b7221e1b13470e34ff01efb8d22bfc0c79 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Aug 09 09:14:54 2018 grit: add video/webm mime type. It turns out that video/webm mime type is not always available (depending on the python version?) So this Cl adds it statically. Bug: 852038 Change-Id: Ic8cb19a777131df96df6c5794598ea8c8d0d312a Reviewed-on: https://chromium-review.googlesource.com/1168655 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#581838} [modify] https://crrev.com/90fc78b7221e1b13470e34ff01efb8d22bfc0c79/tools/grit/grit/format/html_inline.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a99a5a9d02de4f500d759735d6d98d841ee3c312 commit a99a5a9d02de4f500d759735d6d98d841ee3c312 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Aug 10 00:12:37 2018 Reland "ChromeOS OOBE: Add Welcome screen animations." This is a reland of 04b716f7608bea53d0903f821ef0aa4f59741b6d Original change's description: > ChromeOS OOBE: Add Welcome screen animations. > > This Cl replaces static images with animations. > > Bug: 852038 > Change-Id: I8185420aed0ed23c080ac0bc7a2270d3ac4c5b7b > Reviewed-on: https://chromium-review.googlesource.com/1166590 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581735} Bug: 852038 Change-Id: I50659b137bc2e4c1facb7a3b3b734e1a1d3a6500 Reviewed-on: https://chromium-review.googlesource.com/1168328 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#581970} [delete] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/chrome/browser/resources/chromeos/login/images/welcome_illustration_1x.png [delete] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/chrome/browser/resources/chromeos/login/images/welcome_illustration_2x.png [delete] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_1x.png [delete] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_2x.png [delete] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_1x.png [delete] https://crrev.com/97b6e560a9511cf934ba7708faaaa2c0aff63c78/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_2x.png [modify] https://crrev.com/a99a5a9d02de4f500d759735d6d98d841ee3c312/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/a99a5a9d02de4f500d759735d6d98d841ee3c312/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html [modify] https://crrev.com/a99a5a9d02de4f500d759735d6d98d841ee3c312/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
Requesting merge for: feed35d8457a Chrome OS: implement parametrized strings for Sync Consent screen fa5bd50aab4f Chrome OS OOBE: Use Google Sans for OOBE buttons and titles. a99a5a9d02de Reland "ChromeOS OOBE: Add Welcome screen animations." 90fc78b7221e grit: add video/webm mime type. 2dbdbf3056e3 Chrome OS: Unify keyboard focus highlighting of buttons in the list. 7967fd7d6a8f ChromeOS OOBE: Make sure all oobe-dialog receive onBeforeShow event. (approved) 6bb52e3acab1 Chrome OS OOBE: Fix alignment of hd-iron-icon element. 108c1307848d Chrome OS OOBE: Update HID detection screen style.
Expanded list of requested merges: commit feed35d8457a9d0651562b4a5cff0dffb1c0d54f Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Aug 10 20:17:43 2018 +0000 Chrome OS: implement parametrized strings for Sync Consent screen This CL adds I18nBehavior.i18nRecursive and uses it for parametrized strings in Chrome OS Sync Consent screen. Bug: 822889 Change-Id: I0ca8c3b7a45ee1cea8a80a0e8ace388e958709c4 Reviewed-on: https://chromium-review.googlesource.com/1166464 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582309} commit fa5bd50aab4ff15f393a152cb02e8bb0ec113531 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Aug 10 19:43:44 2018 +0000 Chrome OS OOBE: Use Google Sans for OOBE buttons and titles. Bug: 828996,868093 Change-Id: Ic1dd75cc142bd22b2b9edc31bd5b90abe150e081 Reviewed-on: https://chromium-review.googlesource.com/1170430 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#582292} commit a99a5a9d02de4f500d759735d6d98d841ee3c312 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Aug 10 00:12:37 2018 +0000 Reland "ChromeOS OOBE: Add Welcome screen animations." This is a reland of 04b716f7608bea53d0903f821ef0aa4f59741b6d Original change's description: > ChromeOS OOBE: Add Welcome screen animations. > > This Cl replaces static images with animations. > > Bug: 852038 > Change-Id: I8185420aed0ed23c080ac0bc7a2270d3ac4c5b7b > Reviewed-on: https://chromium-review.googlesource.com/1166590 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581735} Bug: 852038 Change-Id: I50659b137bc2e4c1facb7a3b3b734e1a1d3a6500 Reviewed-on: https://chromium-review.googlesource.com/1168328 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#581970} commit 90fc78b7221e1b13470e34ff01efb8d22bfc0c79 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Aug 9 09:14:54 2018 +0000 grit: add video/webm mime type. It turns out that video/webm mime type is not always available (depending on the python version?) So this Cl adds it statically. Bug: 852038 Change-Id: Ic8cb19a777131df96df6c5794598ea8c8d0d312a Reviewed-on: https://chromium-review.googlesource.com/1168655 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#581838} commit 2dbdbf3056e33750e6c5824e4201f8e4e3135282 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Aug 8 07:06:18 2018 +0000 Chrome OS: Unify keyboard focus highlighting of buttons in the list. This Cl unifies buttons layout in the list, and thus makes keyboard focus highliting look the same for all buttons. Bug: 822889 Change-Id: Ic7c1795d72a0f07e5137731874fe4a53e70e729e Reviewed-on: https://chromium-review.googlesource.com/1166294 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581490} commit 7967fd7d6a8fd9c7f7cee16ae6f9eeb5284dd0fb Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Aug 1 23:00:34 2018 +0000 ChromeOS OOBE: Make sure all oobe-dialog receive onBeforeShow event. This CL routes onBeforeShow event to the oobe-dialogs, that are not subnodes of another Polymer object. Bug: 828999 Change-Id: Id2cee750d2364e53052133bbea7d27ea2c1ca0a2 Reviewed-on: https://chromium-review.googlesource.com/1157912 Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#579977} commit 6bb52e3acab110975a7623c656d04179920a79fc Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Aug 1 22:59:31 2018 +0000 Chrome OS OOBE: Fix alignment of hd-iron-icon element. Bug: 828999 Change-Id: I2be47264b2b3140e777b6d711e36b87bfa40daed Reviewed-on: https://chromium-review.googlesource.com/1157914 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#579976} commit 108c1307848d1eef41b20ee17c32c60a1d807925 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Jul 26 22:55:53 2018 +0000 Chrome OS OOBE: Update HID detection screen style. This CL updates HID detection screen with new style. Bug: 852046 Change-Id: Ibba68ae848efeb7518ec1942719da666f5f92f24 Reviewed-on: https://chromium-review.googlesource.com/1150970 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#578470}
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97069ddc5223776c159eb6afaf836aa2b72b1870 commit 97069ddc5223776c159eb6afaf836aa2b72b1870 Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Aug 11 02:59:02 2018 grit: add video/webm mime type. It turns out that video/webm mime type is not always available (depending on the python version?) So this Cl adds it statically. TBR=alemate@chromium.org (cherry picked from commit 90fc78b7221e1b13470e34ff01efb8d22bfc0c79) Bug: 852038 Change-Id: Ic8cb19a777131df96df6c5794598ea8c8d0d312a Reviewed-on: https://chromium-review.googlesource.com/1168655 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581838} Reviewed-on: https://chromium-review.googlesource.com/1171949 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#555} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/97069ddc5223776c159eb6afaf836aa2b72b1870/tools/grit/grit/format/html_inline.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/952b549393e80f000a4525d5df974f0f3ef68d51 commit 952b549393e80f000a4525d5df974f0f3ef68d51 Author: Alexander Alekseev <alemate@google.com> Date: Thu Aug 16 00:55:19 2018 Reland "ChromeOS OOBE: Add Welcome screen animations." This is a reland of 04b716f7608bea53d0903f821ef0aa4f59741b6d Original change's description: > ChromeOS OOBE: Add Welcome screen animations. > > This Cl replaces static images with animations. > > Bug: 852038 > Change-Id: I8185420aed0ed23c080ac0bc7a2270d3ac4c5b7b > Reviewed-on: https://chromium-review.googlesource.com/1166590 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581735} (cherry picked from commit a99a5a9d02de4f500d759735d6d98d841ee3c312) Bug: 852038 Change-Id: I50659b137bc2e4c1facb7a3b3b734e1a1d3a6500 Reviewed-on: https://chromium-review.googlesource.com/1168328 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581970} Reviewed-on: https://chromium-review.googlesource.com/1176830 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#667} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [delete] https://crrev.com/75390a4810097a2fd9b9f444ef2897eeb189d9a1/chrome/browser/resources/chromeos/login/images/welcome_illustration_1x.png [delete] https://crrev.com/75390a4810097a2fd9b9f444ef2897eeb189d9a1/chrome/browser/resources/chromeos/login/images/welcome_illustration_2x.png [delete] https://crrev.com/75390a4810097a2fd9b9f444ef2897eeb189d9a1/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_1x.png [delete] https://crrev.com/75390a4810097a2fd9b9f444ef2897eeb189d9a1/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_2x.png [delete] https://crrev.com/75390a4810097a2fd9b9f444ef2897eeb189d9a1/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_1x.png [delete] https://crrev.com/75390a4810097a2fd9b9f444ef2897eeb189d9a1/chrome/browser/resources/chromeos/login/images/welcome_illustration_tablet_mode_portraight_2x.png [modify] https://crrev.com/952b549393e80f000a4525d5df974f0f3ef68d51/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/952b549393e80f000a4525d5df974f0f3ef68d51/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html [modify] https://crrev.com/952b549393e80f000a4525d5df974f0f3ef68d51/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
Comment 1 by bugdroid1@chromium.org
, Jul 19