New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852034 link

Starred by 4 users
Status: Fixed
Owner:
alemate@chromium.org
Closed: Aug 10
Cc:
█ elizabethchiu@chromium.org
r...@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 828996



Sign in to add a comment

OOBE template update

Project Member Reported by zalcorn@chromium.org, Jun 12 2018 
Template updates for all OOBE screens, including:
- All-white background
- GM2 UI components: buttons, dropdown, textfield, icons, toggles, checkbox
- Google Sans for titles
- Shelf color update

Spec here: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZcWxQVKsUFtK/files/MCGJEufWNx2OfnhmVzPdBozCwMSJbxAVNpw

For GM2 components, please use shared components - contact markchang@ and dpapad@ with questions.

Each screen will also have an individual tracking bug with full spec.

Comment 1 by zalcorn@chromium.org, Jun 12 2018

Description: Show this description

Comment 2 by dpa...@chromium.org, Jun 20 2018 

Regarding WebUI components

 - Shared button styling is at [1]. There exist multiple examples in the code no how to use it, see [2].
 - dropdown, see md-select styling at [3].
 - textfield, see cr-input at [4]
 - toggles, see cr-toggle (already used by OOBE in some cases), see [5].
 - checkbox, see cr-checkbox at [6]


[1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/paper_button_style_css.html
[2] https://cs.chromium.org/search/?q=paper-button-style&type=cs
[3] https://cs.chromium.org/chromium/src/ui/webui/resources/html/md_select_css.html
[4] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_input/cr_input.html
[5] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html
[6] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html

Comment 3 by alemate@chromium.org, Jun 21 2018 

Could you suggest how to create 'inverted' button with the shared button specs?

These specs have { padding: 8px 16px; } specified, which results in this:

https://screenshot.googleplex.com/pt4ALY3EEkA.png

Comment 5 by scottchen@chromium.org, Jun 22 2018 

Hello alemate@,
After I created cr-input, I was planning on replacing all the usages of <paper-input> and <paper-input-container> within any web-ui, with the goal of removing paper-input library completely from our code-base.

I see that there's one within <gaia-input>, but <gaia-input> seems to have a lot of usages in different places, and I think its probably better for your team to switch that out so I don't break anything unknowingly.

Looking at the code[1], I think I built enough features for <cr-input> to support all the things <gaia-input> needs to do, but if you find any feature missing feel free to ping me. There's a bunch of examples of replacing paper- with cr-input in recent CLs[2].

[1]https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/gaia_input.html?type=cs&q=%22%3Cpaper-input%22+file:%5Esrc/chrome/browser/resources/chromeos/login/+package:%5Echromium$&g=0&l=44-58

[2]https://chromium-review.googlesource.com/c/chromium/src/+/1086357

Comment 6 by alemate@chromium.org, Jun 22 2018 

<gaia-input> (and all it's use) is managed my Enterprise team. I cannot test it either.

Let's create a different issue for this.

Comment 7 by alemate@chromium.org, Jun 23 2018

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8628464d9d66de109c49cb517f158a432cb8079f

commit 8628464d9d66de109c49cb517f158a432cb8079f
Author: Alexander Alekseev <alemate@chromium.org>
Date: Sun Jun 24 00:34:13 2018

Chrome OS OOBE: Use new OOBE style.

This implements shared style for the updated UI.

Major changes:
1) oobe-dialog slot="header" replaced with two slots: "title" and "subtitle".
2) shared oobe_dialog_parameters.css removed, all parameters are styled
in oobe-dialog CSS.
3) All dialogs could be displayed both full-screen or windowed.
4) If any dialog is full-screen, all subsequent will also be displayed
with full-screen style.
5) Elements hosting oobe-dialogs must implement OobeDialogHostBehavior.

Bug:  852034 , 852043 ,  852041 

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id282d2f3385def8fc6a376bc85fc32734653e466
Reviewed-on: https://chromium-review.googlesource.com/1111025
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569922}
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/assistant_optin/assistant_confirm_reject.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/assistant_optin/assistant_get_more.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/assistant_optin/assistant_loading.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/assistant_optin/assistant_optin.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/assistant_optin/assistant_ready.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/assistant_optin/assistant_third_party.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/assistant_optin/assistant_value_prop.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/arc_terms_of_service.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/demo_setup.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/encryption_migration.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/encryption_migration.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/offline_gaia.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_a11y_option.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_a11y_option.html
[add] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_back_button.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_buttons.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_dialog.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_dialog.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_dialog.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_dialog_host.css
[add] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_dialog_host_behavior.js
[delete] https://crrev.com/7130ad98c20cc32d710c5bbe10c8cb44899fef10/chrome/browser/resources/chromeos/login/oobe_dialog_parameters.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_eula.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_eula.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_hid_detection.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.css
[delete] https://crrev.com/7130ad98c20cc32d710c5bbe10c8cb44899fef10/chrome/browser/resources/chromeos/login/oobe_nav_button.css
[add] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_next_button.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_reset.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_screen_update.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_screen_voice_interaction_value_prop.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_screen_wait_for_container_ready.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_screen_welcome.html
[add] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_text_buttons.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_update.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_update.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_update.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_wait_for_container_ready.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_wait_for_container_ready.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_wait_for_container_ready.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_welcome.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/recommend_apps.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/recommend_apps.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/screen_confirm_password.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/screen_encryption_migration.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/screen_error_message.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/screen_error_message.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/sync_consent.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/sync_consent.html
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/chrome/browser/resources/chromeos/login/sync_consent.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/ui/login/display_manager.js
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/ui/login/md_screen_container.css
[modify] https://crrev.com/8628464d9d66de109c49cb517f158a432cb8079f/ui/login/oobe.css

Comment 9 by scottchen@chromium.org, Jun 25 2018 

I'll make comment #5 its own bug

Comment 10 by alemate@chromium.org, Jun 25 2018 

Elizabeth, are there specs for the shelf update?
What are the fonts/colors?
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23375dd37c69da1a79e9e98fa3ba9e8c1c426134

commit 23375dd37c69da1a79e9e98fa3ba9e8c1c426134
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu Jun 28 02:27:22 2018

Chrome OS OOBE: make shelf consistent with new UI.

Bug:  852034 , 857221 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I70686fbe59fe1543314ca486ce95e3f2022fe9c6
Reviewed-on: https://chromium-review.googlesource.com/1117853
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571007}
[modify] https://crrev.com/23375dd37c69da1a79e9e98fa3ba9e8c1c426134/chrome/browser/resources/chromeos/login/md_header_bar.css
[modify] https://crrev.com/23375dd37c69da1a79e9e98fa3ba9e8c1c426134/chrome/browser/resources/chromeos/login/md_header_bar.html
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49653cff581108c20acc3c77119645d4128b77ab

commit 49653cff581108c20acc3c77119645d4128b77ab
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Jul 17 01:30:37 2018

Chrome OS: Fix layout of Offline Gaia screen.

This Cl fixes Offline Gaia layout to match new OOBE style from
https://chromium-review.googlesource.com/c/chromium/src/+/1111025 .


BUG:  863266 ,   852034 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibef139a3a685b1be7f8dea52fb9c5f6a5ab73b76
Reviewed-on: https://chromium-review.googlesource.com/1136380
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575511}
[add] https://crrev.com/49653cff581108c20acc3c77119645d4128b77ab/chrome/browser/resources/chromeos/login/offline_ad_login.css
[modify] https://crrev.com/49653cff581108c20acc3c77119645d4128b77ab/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/49653cff581108c20acc3c77119645d4128b77ab/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/49653cff581108c20acc3c77119645d4128b77ab/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/49653cff581108c20acc3c77119645d4128b77ab/chrome/browser/resources/chromeos/login/offline_gaia.js
[modify] https://crrev.com/49653cff581108c20acc3c77119645d4128b77ab/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ui-webui-internal/+/4afc450a9363ab44f45c3639d0661daa7dbe5bda

commit 4afc450a9363ab44f45c3639d0661daa7dbe5bda
Author: Alexander Alekseev <alemate@google.com>
Date: Thu Jul 19 22:23:27 2018
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d

commit c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jul 20 01:00:16 2018

Chrome OS OOBE: Fix button styling.

This Cl makes buttons correctly spaced on Welcome screen and Powerwash screen.
Assistant opt-in screen now uses cros-shared button style.

Bug:  857443 , 852034 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia90416579b6fefa409ccb4eba7eafeb019136409
Reviewed-on: https://chromium-review.googlesource.com/1142894
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576733}
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/assistant_optin/assistant_optin.html
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_dialog.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_reset.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_reset.html
[delete] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/chrome/browser/resources/chromeos/login/oobe_text_button.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_text_buttons.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/efcbbd5122e2bfcdadf33c01ff34cd5eb1d47ec3

commit efcbbd5122e2bfcdadf33c01ff34cd5eb1d47ec3
Author: Alexander Alekseev <alemate@google.com>
Date: Fri Jul 20 01:56:53 2018
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03020af859eba312d0e79d0e1241548dc3523f79

commit 03020af859eba312d0e79d0e1241548dc3523f79
Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 20 03:23:23 2018

Roll src-internal ea9328b8e855..9cf0f36d349f (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea9328b8e855..9cf0f36d349f


Created with:
  gclient setdep -r src-internal@9cf0f36d349f

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:852038 , chromium:852034 
TBR=mmoss@chromium.org

Change-Id: I07282894134f4ba5d4aa6f4888c92d79871a1a1f
Reviewed-on: https://chromium-review.googlesource.com/1144283
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576768}
[modify] https://crrev.com/03020af859eba312d0e79d0e1241548dc3523f79/DEPS
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/f8ad544ab6f9b8c01115703e340e50a0ba4723fd

commit f8ad544ab6f9b8c01115703e340e50a0ba4723fd
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jul 20 12:31:21 2018
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/400a8fdf4bf27579755c2d11ac3ae2b59f447d17

commit 400a8fdf4bf27579755c2d11ac3ae2b59f447d17
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jul 20 19:16:21 2018

Added ui/webui/internal to .gitignore

Bug:  852034 
Change-Id: Iac5c70336e3868521b8dbfd81c2238122438b466
Reviewed-on: https://chromium-review.googlesource.com/1144631
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576946}
[modify] https://crrev.com/400a8fdf4bf27579755c2d11ac3ae2b59f447d17/.gitignore
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/dafbc08c28d4af6bae9e7ec458bb149b0c7de7cd

commit dafbc08c28d4af6bae9e7ec458bb149b0c7de7cd
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Jul 25 07:14:44 2018

Add Google Sans system fonts.

Google sans fonts are installed to /usr/share/fonts/google-sans.

BUG=chromium:817018, chromium:852034 
TEST=emerge-${BOARD} chromeos-fonts succeeds

Change-Id: Ie9f19e7ea30929ce6f32de7a817d080131b67ff8
Reviewed-on: https://chromium-review.googlesource.com/1146141
Commit-Ready: Alexander Alekseev <alemate@chromium.org>
Tested-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>

[rename] https://crrev.com/dafbc08c28d4af6bae9e7ec458bb149b0c7de7cd/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1-r30.ebuild
[modify] https://crrev.com/dafbc08c28d4af6bae9e7ec458bb149b0c7de7cd/media-libs/fontconfig/files/local.conf
[rename] https://crrev.com/dafbc08c28d4af6bae9e7ec458bb149b0c7de7cd/media-libs/fontconfig/fontconfig-2.11.1-r25.ebuild
[modify] https://crrev.com/dafbc08c28d4af6bae9e7ec458bb149b0c7de7cd/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1.ebuild
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 10

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7a027f76e12936127bb10cf322a82df47f1fba47

commit 7a027f76e12936127bb10cf322a82df47f1fba47
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Aug 10 20:26:00 2018

Add Google Sans system fonts.

Google sans fonts are installed to /usr/share/fonts/google-sans.

BUG=chromium:817018, chromium:852034 
TEST=emerge-${BOARD} chromeos-fonts succeeds

Change-Id: Ie9f19e7ea30929ce6f32de7a817d080131b67ff8
Reviewed-on: https://chromium-review.googlesource.com/1146141
Commit-Ready: Alexander Alekseev <alemate@chromium.org>
Tested-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
(cherry picked from commit dafbc08c28d4af6bae9e7ec458bb149b0c7de7cd)
Reviewed-on: https://chromium-review.googlesource.com/1171602
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>

[rename] https://crrev.com/7a027f76e12936127bb10cf322a82df47f1fba47/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1-r30.ebuild
[modify] https://crrev.com/7a027f76e12936127bb10cf322a82df47f1fba47/media-libs/fontconfig/files/local.conf
[rename] https://crrev.com/7a027f76e12936127bb10cf322a82df47f1fba47/media-libs/fontconfig/fontconfig-2.11.1-r25.ebuild
[modify] https://crrev.com/7a027f76e12936127bb10cf322a82df47f1fba47/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1.ebuild

Comment 22 by alemate@chromium.org, Aug 10

Status: Fixed (was: Started)
►

Sign in to add a comment