New issue
Advanced search Search tips

Issue 852014 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT export] close PRs from abandoned CLs

Project Member Reported by geoff...@gmail.com, Jun 12 2018

Issue description

See, e.g., https://github.com/web-platform-tests/wpt/pull/11423 from https://chromium-review.googlesource.com/c/1091800/. There's no reason the PR should remain open; it should be automatically closed when the CL is abandoned (and reopened if it's restored).
 
Status: Available (was: Untriaged)
Labels: Hotlist-GoodFirstBug
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c

commit e118e82e85689dc5efc4bf0bb344c4c74bd90e2c
Author: kyle Ju <kyleju@chromium.org>
Date: Wed Oct 10 21:31:20 2018

Create a script that closes all PRs corresponding to abandoned CLs in Gerrit.

Command:
python third_party/blink/tools/wpt_cleanup.py --credentials-json ~/CREDENTIALS.json

Bug:  852014 

Change-Id: I58e081eefa1cea456ca7e402405f558169eaf9ad
Reviewed-on: https://chromium-review.googlesource.com/c/1240853
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598516}
[modify] https://crrev.com/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c/third_party/blink/tools/blinkpy/w3c/gerrit.py
[modify] https://crrev.com/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c/third_party/blink/tools/blinkpy/w3c/gerrit_mock.py
[add] https://crrev.com/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c/third_party/blink/tools/blinkpy/w3c/pr_cleanup_tool.py
[add] https://crrev.com/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c/third_party/blink/tools/blinkpy/w3c/pr_cleanup_tool_unittest.py
[modify] https://crrev.com/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c/third_party/blink/tools/blinkpy/w3c/wpt_github.py
[modify] https://crrev.com/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c/third_party/blink/tools/blinkpy/w3c/wpt_github_mock.py
[modify] https://crrev.com/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c/third_party/blink/tools/blinkpy/w3c/wpt_github_unittest.py
[add] https://crrev.com/e118e82e85689dc5efc4bf0bb344c4c74bd90e2c/third_party/blink/tools/wpt_cleanup.py

Another edge case raised in https://github.com/web-platform-tests/wpt/issues/14199:

PRs whose original CLs have been submitted but no longer with exportable changes should also be closed.

Kyle, could you add this edge case to your cleanup tool?
Owner: kyleju@chromium.org
Status: Assigned (was: Available)
Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46c9d5ef85ac910175eaeb1c4c44f708cde94f5f

commit 46c9d5ef85ac910175eaeb1c4c44f708cde94f5f
Author: kyle Ju <kyleju@chromium.org>
Date: Tue Nov 27 17:26:57 2018

Add an edge case to PR clenaup tool.

Address the edge case where when a CL no longer has exportable changes, the PR should
be closed and the branch should be deleted.


Bug:  852014 ,  750942 
Change-Id: I86adf85a3dcec7a9fac088fa42e2e357bbf1285a
Reviewed-on: https://chromium-review.googlesource.com/c/1349471
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611164}
[modify] https://crrev.com/46c9d5ef85ac910175eaeb1c4c44f708cde94f5f/third_party/blink/tools/blinkpy/w3c/pr_cleanup_tool.py
[modify] https://crrev.com/46c9d5ef85ac910175eaeb1c4c44f708cde94f5f/third_party/blink/tools/blinkpy/w3c/pr_cleanup_tool_unittest.py

Sign in to add a comment