New issue
Advanced search Search tips

Issue 852013 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Touch-action rects are incorrect with writing-mode: vertical-rl

Project Member Reported by pdr@chromium.org, Jun 12 2018

Issue description

Chrome Version: 69.0.3451.0/dev
OS: MacOS

What steps will reproduce the problem?
(1) Open the attached touchactionrl.html
(2) Open the inspector and enable "Scrolling performance issues" under the "rendering" tab.
(3) Notice the touch action rects are incorrect.

 
touchactionrl.html
342 bytes View Download
Labels: Hotlist-Polish
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33acc1ce6e24169847e37200f680dc7e451a12a1

commit 33acc1ce6e24169847e37200f680dc7e451a12a1
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Jun 13 18:43:19 2018

Update inline touch action rects during paint

This patch extends support for painting touch action rects (behind the
PaintTouchActionRects flag) to inline painting. With this patch, the
inline box's background hit test rect is painted. To reduce duplicate
code, InlineFlowBoxPainter::AdjustedPaintRect was introduced.

Because touch action rects are painted the same way as backgrounds, this
approach correctly handles vertical-rl writing modes.

Bug: 836905,  852013 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I53296e0fc6e939e220a90fee40e07492a9da113a
Reviewed-on: https://chromium-review.googlesource.com/1097562
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566932}
[modify] https://crrev.com/33acc1ce6e24169847e37200f680dc7e451a12a1/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/33acc1ce6e24169847e37200f680dc7e451a12a1/third_party/blink/renderer/core/paint/inline_flow_box_painter.cc
[modify] https://crrev.com/33acc1ce6e24169847e37200f680dc7e451a12a1/third_party/blink/renderer/core/paint/inline_flow_box_painter.h
[add] https://crrev.com/33acc1ce6e24169847e37200f680dc7e451a12a1/third_party/blink/renderer/core/testing/data/touch-action-on-inline.html
[add] https://crrev.com/33acc1ce6e24169847e37200f680dc7e451a12a1/third_party/blink/renderer/core/testing/data/touch-action-with-vertical-rl-writing-mode.html

Status: Fixed (was: Assigned)
This bug is fixed under --enable-blink-features=PaintTouchActionRects

Sign in to add a comment