New tab animation runs on top of the bottom toolbar |
||||
Issue descriptionSteps to repro: - Enter tab switcher. - Create a new tab from either the new tab button or overflow menu item. The toolbar gets drawn over and then pops back on-screen when the animation completes. We should update the animation so that it plays behind the bottom toolbar.
,
Aug 1
,
Aug 10
,
Aug 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9226b58bb77c84fd444da9d423199356bea96673 commit 9226b58bb77c84fd444da9d423199356bea96673 Author: Matthew Jones <mdjones@chromium.org> Date: Sat Aug 11 00:00:32 2018 Fix new tab animation from tab switcher in Duet This patch changes the container that the new tab animation runs in when Duet is enabled. The container changes position from running on top of the toolbars to running beneath them (since the bottom toolbar is a persistent fixture). This would negatively impact the top toolbar if there were still icons there (since the top toolbar has an appearance animation to compensate for the tab appearing on top of it). However, since there are no icons, it is not an issue. Bug: 852012 Change-Id: I19422b70844f3fd45e7d9318a3c9c9768b407991 Reviewed-on: https://chromium-review.googlesource.com/1171819 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582391} [modify] https://crrev.com/9226b58bb77c84fd444da9d423199356bea96673/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayoutBase.java
,
Aug 13
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mdjones@chromium.org
, Jun 28 2018