New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852007 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-21
OS: Mac
Pri: 3
Type: Feature



Sign in to add a comment

Edit search engines should open search engine for current address

Reported by yuriko...@gmail.com, Jun 12 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3451.0 Safari/537.36

Steps to reproduce the problem:
1. Open some site which has custom search engine
2. Right click on omnibox -> Edit search engines

What is the expected behavior?
Current site's search engine editing dialog should appear.

What went wrong?
Chrome shows list of all search engines.

Did this work before? No 

Chrome version: 69.0.3451.0  Channel: dev
OS Version: OS X 10.13.5
Flash Version:
 
Labels: Needs-Triage-M69
Status: Available (was: Unconfirmed)

Comment 3 by yuriko...@gmail.com, Jun 13 2018

What is available? In which version?

Comment 4 by meh...@chromium.org, Jun 13 2018

Available means that the issue is confirmed, but no owner is assigned yet :)


Comment 5 by meh...@chromium.org, Jun 13 2018

Components: -UI UI>Browser>Omnibox
Cc: dschuyler@chromium.org
Components: UI>Settings UI>Browser>Search
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
It looks like the Setting's page's search engine's sub-pane doesn't support deep-linking, e.g., chrome://settings/searchEngines?yahoo and chrome://settings/searchEngines#yahoo doesn't work.

We'd need that to work to make the omnibox - > Edit Search Engine to go to the appropriate place.

CC dschuyler, because I think he worked on settings pages at some point in the past.  Maybe he can help triage.

Comment 7 by dpa...@chromium.org, Jun 13 2018

Deep linking inside the chrome://settings/searchEngines is not supported. What viiew would you consider the "appropriate place"? Are you suggesting that the edit search engine dialog should be open when deep linking is used?
Responding to #6, dpapad@ is the expert here (and responding in #7). 
@7:
I think the user is expecting to see the search engine sub-pane showing only the particular search engine that was in use / associated with the URL upon which the user selected "Edit search engine."
There search engines view does not have a way to force showing a single entry in the list. It supports filtering, which may result in no results, multiple results, or single result (see screenshots). It also uses a dialog for editing a single search engine.

IIUC, there are the following alternatives when "edit search engines" is clicked in the 

1) Current approach: Open chrome://settings/searchEngines, and let the user figure out which engine they want to edit. After all the item they clicked on says "edit search engines", and does not specify which site's engines to edit.

2) Open chrome://settings/searchEngines with a search filter, which may show multiple search engines. Let the user figure out which one of the shown engines they want to edit.

3) Open chrome://settings/searchEngines with the "edit" dialog already open for a given engine.

4) Introduce a new mechanism, which is not "filtering", that makes the list only display a single engine. Then let the user open the dialog themselves.


#4 does not sound like a good solution to me, because it does not use filtering, therefore provides no explanation to the user of why other engines are hidden. It still requires the user to open the dialog themselves. Happy to hear thoughts. Either way, this seems like a P3 and I don't think it can be addressed before M70.
search.png
54.3 KB View Download
search_single_result.png
28.7 KB View Download
search_engines_edit.png
59.0 KB View Download
NextAction: 2018-06-21
dpapad@,

That's a good question about which behavior we want.  When looking at this closer, I realized I misunderstood something.  I thought we'd have an idea of the relevant search engine when the user clicks "Edit search engine".  But that's not the case.  The option appears all the time, whether or not text typed displayed in the omnibox is a URL or a query, and, in the case of URLs, regardless of whether that hostname has a search engine associate with it.

Identifying the relevant search engine (when possible) and deep-linking it is going to be a pain.  And deep-linking to the default search engine all the time seems inappropriate.

I'm tempted to close this as simply infeasible (not worth fixing).

Leaving open for a week for second opinions.
The NextAction date has arrived: 2018-06-21
Status: WontFix (was: Available)
It appear no one had second opinions.  I'm going to close as infeasible (not worth fixing).  (Sorry yurikoles@)

Sign in to add a comment