SandboxWinTest.AppContainerUnsupportedType fails on win10_chromium_x64_rel_ng |
|||
Issue descriptionservice_manager_unittests is currently disabled on win10_chromium_x64_rel_ng . If I enable it, SandboxWinTest.AppContainerUnsupportedType fails: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10_chromium_x64_rel_ng/27031 [ RUN ] SandboxWinTest.AppContainerUnsupportedType [6360:6580:0612/074046.383:6022281:FATAL:sandbox_win.cc(596)] Check failed: sandbox_type == service_manager::SANDBOX_TYPE_GPU. Backtrace: base::debug::StackTrace::StackTrace [0x00007FF6B86802C4+36] logging::LogMessage::~LogMessage [0x00007FF6B8616A02+98] service_manager::SandboxWin::AddAppContainerProfileToPolicy [0x00007FF6B867482A+126] service_manager::SandboxWinTest_AppContainerAccessCheckFail_Test::TestBody [0x00007FF6B8592508+858] service_manager::SandboxWinTest_AppContainerUnsupportedType_Test::TestBody [0x00007FF6B859359A+94] testing::Test::Run [0x00007FF6B85AF115+199] testing::TestInfo::Run [0x00007FF6B85AF7B6+222] testing::TestCase::Run [0x00007FF6B85AFCE8+258] testing::internal::UnitTestImpl::RunAllTests [0x00007FF6B85B6DF4+638] testing::UnitTest::Run [0x00007FF6B85B6ACF+165] base::TestSuite::Run [0x00007FF6B864DF26+118] base::OnceCallback<int __cdecl(void)>::Run [0x00007FF6B864FF00+54] base::LaunchUnitTests [0x00007FF6B864F0FF+551] base::LaunchUnitTests [0x00007FF6B864EF97+191] service_manager::InitializeAndLaunchUnitTests [0x00007FF6B85FF261+269] main [0x00007FF6B85A00F9+169] __scrt_common_main_seh [0x00007FF6B8760098+268] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x00007FFC584E2774+20] RtlUserThreadStart [0x00007FFC5A840D51+33]
,
Jun 12 2018
,
Jun 12 2018
once it's fixed you want to do something like https://chromium-review.googlesource.com/c/chromium/src/+/1097197/1/testing/buildbot/test_suite_exceptions.pyl#b1882 to make sure the binary runs everywhere
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/085f9cff64b120838365006cc9120c555c9da342 commit 085f9cff64b120838365006cc9120c555c9da342 Author: Will Harris <wfh@chromium.org> Date: Wed Jun 13 16:00:34 2018 Remove SandboxWinTest.AppContainerUnsupportedType test. This is already checked with a DCHECK in the code that the test was hitting. I prefer to remove the test than remove the DCHECK, as the DCHECK is likely preventing more future incorrect use of this api than having a test that fails on a certain incorrect use. BUG= 852004 Change-Id: I79d4d58ed495684a26ad71b680b72e32452089b3 Reviewed-on: https://chromium-review.googlesource.com/1097709 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#566850} [modify] https://crrev.com/085f9cff64b120838365006cc9120c555c9da342/services/service_manager/tests/sandbox/sandbox_win_unittest.cc [modify] https://crrev.com/085f9cff64b120838365006cc9120c555c9da342/testing/buildbot/chromium.win.json [modify] https://crrev.com/085f9cff64b120838365006cc9120c555c9da342/testing/buildbot/test_suite_exceptions.pyl
,
Jun 14 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wfh@chromium.org
, Jun 12 2018Labels: -OS-Linux -Pri-3 Test-Disabled OS-Windows Pri-2
Owner: ----
Status: Available (was: Untriaged)