New issue
Advanced search Search tips

Issue 851994 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ASSERT: false

Project Member Reported by ClusterFuzz, Jun 12 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5673793503363072

Fuzzer: libFuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  false
  CPDF_Object::MakeReference
  CPDF_Array::ConvertToIndirectObjectAt
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=566274:566287

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5673793503363072

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 12 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 12 2018

Cc: dsinclair@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jun 12 2018

Cc: art-sn...@yandex-team.ru
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Implement CPDF_Object::MakeReference method. by art-snake@yandex-team.ru - https://pdfium.googlesource.com/pdfium/+/fb72726e51bfd0c7bfc61c9b354e2b60f46adac5

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Labels: -Type-Bug M-69 CF-NeedsTriage Type-Bug-Regression
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/30688fb1c434b141380aa224da12e8246a8a78e1

commit 30688fb1c434b141380aa224da12e8246a8a78e1
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Jul 18 05:07:28 2018

Do not add invalid objects to the cross reference table.

BUG= chromium:851994 

Change-Id: I2e14401271c70afa204221e0f3d469f0b82ce8cf
Reviewed-on: https://pdfium-review.googlesource.com/37871
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Art Snake <art-snake@yandex-team.ru>

[modify] https://crrev.com/30688fb1c434b141380aa224da12e8246a8a78e1/core/fpdfapi/parser/cpdf_cross_ref_table.cpp
[modify] https://crrev.com/30688fb1c434b141380aa224da12e8246a8a78e1/core/fpdfapi/parser/cpdf_parser.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4f8b7e4ff3788a9cbdd63f0a570ca9bd8299f92

commit b4f8b7e4ff3788a9cbdd63f0a570ca9bd8299f92
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jul 18 11:28:25 2018

Roll src/third_party/pdfium 89063ecda876..30688fb1c434 (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/89063ecda876..30688fb1c434


git log 89063ecda876..30688fb1c434 --date=short --no-merges --format='%ad %ae %s'
2018-07-18 thestig@chromium.org Do not add invalid objects to the cross reference table.
2018-07-18 thestig@chromium.org Avoid writing const/non-const versions of the same function.
2018-07-18 art-snake@yandex-team.ru Use CPDF_CrossRefTable within CPDF_Parser
2018-07-18 art-snake@yandex-team.ru Make CPDF_Parser::GetTrailer const method.


Created with:
  gclient setdep -r src/third_party/pdfium@30688fb1c434

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:851994 
TBR=dsinclair@chromium.org

Change-Id: Ifa585071269b19dea2a21848eac1e7bce60e1711
Reviewed-on: https://chromium-review.googlesource.com/1141604
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576004}
[modify] https://crrev.com/b4f8b7e4ff3788a9cbdd63f0a570ca9bd8299f92/DEPS

Project Member

Comment 9 by ClusterFuzz, Jul 18

ClusterFuzz has detected this issue as fixed in range 576000:576006.

Detailed report: https://clusterfuzz.com/testcase?key=5673793503363072

Fuzzer: libFuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  false
  CPDF_Object::MakeReference
  CPDF_Array::ConvertToIndirectObjectAt
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=566274:566287
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=576000:576006

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5673793503363072

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jul 18

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5673793503363072 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
 Issue 864678  has been merged into this issue.

Sign in to add a comment