Issue metadata
Sign in to add a comment
|
"FolderShortcuts/FilesAppBrowserTest.Test/addRemoveFolderShortcuts" is flaky |
||||||||||||||||||||||||
Issue description"FolderShortcuts/FilesAppBrowserTest.Test/addRemoveFolderShortcuts" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFGb2xkZXJTaG9ydGN1dHMvRmlsZXNBcHBCcm93c2VyVGVzdC5UZXN0L2FkZFJlbW92ZUZvbGRlclNob3J0Y3V0cww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 18 2018
Similar to bug 852055 , looks like this occasionally times out on ASan LSan but is otherwise fine. This one is much more frequent though, so might have to disable on ASan/LSan.
,
Jun 18 2018
,
Jun 18 2018
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/210d3b47ff5bff7ca989f5126ef00c7245a7ecbc commit 210d3b47ff5bff7ca989f5126ef00c7245a7ecbc Author: Marc Treib <treib@chromium.org> Date: Mon Jun 18 14:07:26 2018 Disable FolderShortcuts/FilesAppBrowserTest on ASan It's too slow and times out. TBR=fukino@chromium.org Bug: 851988 Change-Id: I868d846e3fae5f7dd16b2a2c7203602008221396 Reviewed-on: https://chromium-review.googlesource.com/1104424 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567991} [modify] https://crrev.com/210d3b47ff5bff7ca989f5126ef00c7245a7ecbc/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Jun 18 2018
,
Jun 19 2018
Logs in the List of all flakes from https://chromium-try-flakes.appspot.com in the OP say: [6664:6664:0612/055926.363102:INFO:CONSOLE(296)] "Uncaught (in promise) TypeError: Cannot read property 'sort' of undefined", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/remote_call.js (296) BrowserTestBase received signal: Terminated. [30209:30209:0612/045430.264310:INFO:CONSOLE(174)] "Uncaught (in promise) TypeError: Cannot read property 'length' of undefined", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/remote_call.js (174) BrowserTestBase received signal: Terminated. etc, which is a change in behavior in these tests. And searching crbug for those strings, we find issue 852246 . A V8 roll crrev.com/566206 [1] introduced this the change in test behavior, and since it affected JS Array types, that was quickly fixed within a day. [1] https://crbug.com/852246#c12 The try flakes data is accurate in two ways: that a regression was introduced, and that is was fixed (no reports after 2018-06-12, and test active).
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b387bc4704ed6843e1325baf03f89069a1647d99 commit b387bc4704ed6843e1325baf03f89069a1647d99 Author: Noel Gordon <noel@chromium.org> Date: Tue Jun 19 00:37:47 2018 Revert "Disable FolderShortcuts/FilesAppBrowserTest on ASan" This reverts commit 210d3b47ff5bff7ca989f5126ef00c7245a7ecbc. Reason for revert: https://crbug.com/852246#c12 , this issue was fixed already, no need to revert. "Slowness and times out": not so per the logs. They were reporting JS exceptions were being thrown in test due to JS Array being 'undefined', issue 852246 . Original change's description: > Disable FolderShortcuts/FilesAppBrowserTest on ASan > > It's too slow and times out. > > TBR=fukino@chromium.org > > Bug: 851988 > Change-Id: I868d846e3fae5f7dd16b2a2c7203602008221396 > Reviewed-on: https://chromium-review.googlesource.com/1104424 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567991} TBR=fukino@chromium.org,treib@chromium.org Change-Id: Ia287519344b7aeecc03da8539fc4448e1224c740 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851988 , 852246 Reviewed-on: https://chromium-review.googlesource.com/1105537 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568261} [modify] https://crrev.com/b387bc4704ed6843e1325baf03f89069a1647d99/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Jun 19 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dpranke@chromium.org
, Jun 15 2018