New issue
Advanced search Search tips

Issue 851984 link

Starred by 3 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Jun 2018
Cc:
pbos@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacViews/MDRefresh] Close icon on Menus and Downloads Bar show ripple effect when clicking on it

Project Member Reported by meh...@chromium.org, Jun 12 2018 
Chrome Version: Canary 69.0.3455.0 
OS: macOS 10.13.5

What steps will reproduce the problem?
(1) Enable MacViews and MDRefresh
(2) Visit a page
(3) Click on Security Chip, so that the Menu appears
(4) Now click on the close icon

What is the expected result?
No ripple effects on macOS.

What happens instead?
Ripple effect appears.

A screencast is attached.

This happens also on the close icon of the Bookmarks Star Menu or of the Downloads Bar.

Thanks
Mehmet
Close_Ripple.mov
643 KB View Download

Comment 1 by pbos@chromium.org, Jun 12 2018

Owner: pbos@chromium.org
Status: Started (was: Untriaged)

Comment 2 by pbos@chromium.org, Jun 13 2018

Cc: nyerramilli@chromium.org rbasuvula@chromium.org
 Issue 850454  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eed64e02c0948cb2ac5eb154f8087e9b625f01e

commit 5eed64e02c0948cb2ac5eb154f8087e9b625f01e
Author: Peter Boström <pbos@chromium.org>
Date: Wed Jun 13 17:53:11 2018

Hide ink-drop highlight on ripple on all platforms

As ink-drop ripples were recently enabled on all platforms (but
instantaneous on Mac) we need to hide the ink-drop highlight when
showing the ripple. This is because the highlight and ripple have
different shapes by default and we should not show one overlapping the
other.

Bug:  chromium:851984 
Change-Id: I0c5390d26a7faa3a3d39709cd52c4066adb22197
Reviewed-on: https://chromium-review.googlesource.com/1097800
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566903}
[modify] https://crrev.com/5eed64e02c0948cb2ac5eb154f8087e9b625f01e/ui/views/animation/ink_drop_impl.cc

Comment 4 by pbos@chromium.org, Jun 13 2018

Status: Fixed (was: Started)

Comment 5 by meh...@chromium.org, Jun 13 2018 

Hey pbos@. Thanks for fixing it. I tried latest Snapshot #566950 and I am still seeing the behavior with the ink-drop ripple - but a little bit in another way. Before the change the ink-drop ripple was translucent. Now it is completely opaque. Not sure if the round click button is intended.

Enclosed a screencast.

Thanks
Mehmet
Screencast #566950.mov
841 KB View Download

Comment 6 by pbos@chromium.org, Jul 9 

Sorry for responding late, I filed  issue 861975  for this. I think the close button should use an inkdrop circle with a flood-fill effect which would make Mac look fine too.

Comment 7 by meh...@chromium.org, Jul 10 

> Sorry for responding late, I filed  issue 861975  for this. I think the close button should use an inkdrop circle with a flood-fill effect which would make Mac look fine too.

No problem :-) and thanks for filing  issue 861975 .
►

Sign in to add a comment