New issue
Advanced search Search tips

Issue 851948 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove TimelineBasedPageTest

Project Member Reported by perezju@chromium.org, Jun 12 2018

Issue description

This is a hold over from the time when the shared_state used the (page)_test to add hooks around story execution.

It should be possible to finally remove the class with little effort now, as it seems that only TabForPage from the parent class still contains code (which could be easily moved to the shared state now).
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e49065b632a0e741e7ad6bd19a9728f46ac42a1c

commit e49065b632a0e741e7ad6bd19a9728f46ac42a1c
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jun 13 04:14:23 2018

Roll src/third_party/catapult fdacd1639e2a..459c4d0417df (5 commits)

https://chromium.googlesource.com/catapult.git/+log/fdacd1639e2a..459c4d0417df


git log fdacd1639e2a..459c4d0417df --date=short --no-merges --format='%ad %ae %s'
2018-06-12 benjhayden@chromium.org Add an index for GetAlertsAroundRevision for non-internal users.
2018-06-12 achuith@chromium.org oobe: Also support gaiastaging.
2018-06-12 nednguyen@google.com Revert "[Sheriff] Disable telemetry.internal.browser.browser_unittest.BrowserTest.testForegroundTab"
2018-06-12 nednguyen@google.com Revert "Disable BrowserTest.testActivateTab on Mac"
2018-06-12 perezju@chromium.org [Telemetry] Remove measurement property from TimelineBasedPageTest


Created with:
  gclient setdep -r src/third_party/catapult@459c4d0417df

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:851463,chromium:851463, chromium:851948 
TBR=sullivan@chromium.org

Change-Id: Ib82446d7c3fe1aa9f915886dfdee5059fecd4bf1
Reviewed-on: https://chromium-review.googlesource.com/1097817
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566716}
[modify] https://crrev.com/e49065b632a0e741e7ad6bd19a9728f46ac42a1c/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7749ee9c81a11c02c8b33cdfd80ec23f78c19be5

commit 7749ee9c81a11c02c8b33cdfd80ec23f78c19be5
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Dec 21 09:42:26 2018

[Telemetry] Remove LegacyPageTest.TabForPage

No clients override this method, so it can be simplified and safely
moved to the shared state instead.

Bug:  chromium:851948 
Change-Id: Iad04a41e0f809f5900ab3897de2c05500b255fc3
Reviewed-on: https://chromium-review.googlesource.com/c/1386905
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/7749ee9c81a11c02c8b33cdfd80ec23f78c19be5/telemetry/telemetry/testing/page_test_test_case.py
[modify] https://crrev.com/7749ee9c81a11c02c8b33cdfd80ec23f78c19be5/telemetry/telemetry/page/shared_page_state.py
[modify] https://crrev.com/7749ee9c81a11c02c8b33cdfd80ec23f78c19be5/telemetry/telemetry/web_perf/timeline_based_page_test.py
[modify] https://crrev.com/7749ee9c81a11c02c8b33cdfd80ec23f78c19be5/telemetry/telemetry/page/legacy_page_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6de01bf77212792a1307576105fd75c0ae652e2f

commit 6de01bf77212792a1307576105fd75c0ae652e2f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Dec 21 16:30:09 2018

Roll src/third_party/catapult 2f6c18c2d5aa..4ee958e1f521 (5 commits)

https://chromium.googlesource.com/catapult.git/+log/2f6c18c2d5aa..4ee958e1f521


git log 2f6c18c2d5aa..4ee958e1f521 --date=short --no-merges --format='%ad %ae %s'
2018-12-21 perezju@chromium.org Revert "Adds ability to pass tags to Typ from browser test suites"
2018-12-21 crouleau@chromium.org [Telemetry] Remove deprecated --smoke-test-mode flag
2018-12-21 perezju@chromium.org [Telemetry] Remove LegacyPageTest.TabForPage
2018-12-21 lwsong@google.com Fixes for Metrics Visualization
2018-12-21 rmhasan@google.com Adds ability to pass tags to Typ from browser test suites


Created with:
  gclient setdep -r src/third_party/catapult@4ee958e1f521

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:835690 ,chromium:894254, chromium:851948 , chromium:835690 
TBR=sullivan@chromium.org

Change-Id: Ic0ce5e1219d7c4582c1ac05862f18feb95b401cf
Reviewed-on: https://chromium-review.googlesource.com/c/1388379
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618545}
[modify] https://crrev.com/6de01bf77212792a1307576105fd75c0ae652e2f/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d6563a5c6d8efbcfecff81d29015c7c7d44cabc0

commit d6563a5c6d8efbcfecff81d29015c7c7d44cabc0
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Wed Jan 02 10:43:52 2019

[Telemetry] Remove public shared_page_state.page_test

This allows containing all references to the legacy "test" objects
within the shared page state itself.

Bug:  chromium:851948 
Change-Id: Ief37f95c6e5cb3adf927e821e2431470d59b3516
Reviewed-on: https://chromium-review.googlesource.com/c/1387919
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>

[modify] https://crrev.com/d6563a5c6d8efbcfecff81d29015c7c7d44cabc0/telemetry/telemetry/page/page_unittest.py
[modify] https://crrev.com/d6563a5c6d8efbcfecff81d29015c7c7d44cabc0/telemetry/telemetry/page/__init__.py
[modify] https://crrev.com/d6563a5c6d8efbcfecff81d29015c7c7d44cabc0/telemetry/telemetry/page/shared_page_state.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6a88c9741a99b314b3d59b7e388af73267e081e

commit d6a88c9741a99b314b3d59b7e388af73267e081e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 02 10:43:40 2019

Roll src/third_party/catapult 16717a6dde42..3ce0041c36f9 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/16717a6dde42..3ce0041c36f9


git log 16717a6dde42..3ce0041c36f9 --date=short --no-merges --format='%ad %ae %s'
2019-01-02 perezju@chromium.org [Telemetry] Remove deprecated LegacyPageTest.RunNavigateSteps


Created with:
  gclient setdep -r src/third_party/catapult@3ce0041c36f9

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:851948 
TBR=sullivan@chromium.org

Change-Id: I78067edb43f4050d40e1933d25ecfde074ee36ae
Reviewed-on: https://chromium-review.googlesource.com/c/1393102
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619386}
[modify] https://crrev.com/d6a88c9741a99b314b3d59b7e388af73267e081e/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2ed26f4f4b02065e00e1cb575f29e47af31666d

commit d2ed26f4f4b02065e00e1cb575f29e47af31666d
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 02 11:45:55 2019

Roll src/third_party/catapult 3ce0041c36f9..d6563a5c6d8e (1 commits)

https://chromium.googlesource.com/catapult.git/+log/3ce0041c36f9..d6563a5c6d8e


git log 3ce0041c36f9..d6563a5c6d8e --date=short --no-merges --format='%ad %ae %s'
2019-01-02 perezju@chromium.org [Telemetry] Remove public shared_page_state.page_test


Created with:
  gclient setdep -r src/third_party/catapult@d6563a5c6d8e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:851948 
TBR=sullivan@chromium.org

Change-Id: If1f4b452fb83cc0d94436dfbc6af30d59ecbff2d
Reviewed-on: https://chromium-review.googlesource.com/c/1393244
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619388}
[modify] https://crrev.com/d2ed26f4f4b02065e00e1cb575f29e47af31666d/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/24bb5c49673beb7c00fdaa58d408a390d47bdc65

commit 24bb5c49673beb7c00fdaa58d408a390d47bdc65
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Wed Jan 02 12:31:33 2019

[Telemetry] Remove LegacyPageTest.close_tabs_before_run

No client sets this to anything other than True. Let's remove the option
to reduce code complexity and help the eventual deprecation of
LegacyPageTest.

Bug:  chromium:851948 
Change-Id: I932e1f978c3f124a16462d4a91041cf6d245dc11
Reviewed-on: https://chromium-review.googlesource.com/c/1387918
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>

[modify] https://crrev.com/24bb5c49673beb7c00fdaa58d408a390d47bdc65/telemetry/telemetry/page/shared_page_state.py
[modify] https://crrev.com/24bb5c49673beb7c00fdaa58d408a390d47bdc65/telemetry/telemetry/page/legacy_page_test.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b534c04aad7286ad64ec992ce7559a15a21107ca

commit b534c04aad7286ad64ec992ce7559a15a21107ca
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 02 13:52:31 2019

Roll src/third_party/catapult d6563a5c6d8e..24bb5c49673b (1 commits)

https://chromium.googlesource.com/catapult.git/+log/d6563a5c6d8e..24bb5c49673b


git log d6563a5c6d8e..24bb5c49673b --date=short --no-merges --format='%ad %ae %s'
2019-01-02 perezju@chromium.org [Telemetry] Remove LegacyPageTest.close_tabs_before_run


Created with:
  gclient setdep -r src/third_party/catapult@24bb5c49673b

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:851948 
TBR=sullivan@chromium.org

Change-Id: I44e0b8eda53fb1c1e616d3a597619544e41f72fc
Reviewed-on: https://chromium-review.googlesource.com/c/1393250
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619392}
[modify] https://crrev.com/b534c04aad7286ad64ec992ce7559a15a21107ca/DEPS

Cc: -nednguyen@chromium.org crouleau@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/51771a7cad87fdf00c949740c06205e71de8830a

commit 51771a7cad87fdf00c949740c06205e71de8830a
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Jan 04 09:14:33 2019

[telemetry] Remove TimelineBasedPageTest from record_wpr.py

The soon to be deprecated class is already a no-op for all its method
calls, so it can be cleanly removed from record_wpr.

Also take the chance to make RecorderPageTest attributes private so
we don't have to worry about external clients making unexpected
changes.

Bug:  chromium:851948 
Change-Id: I2c1b197f1efc9445f398059ff9fb36b4d47cac7e
Reviewed-on: https://chromium-review.googlesource.com/c/1394565
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/51771a7cad87fdf00c949740c06205e71de8830a/telemetry/telemetry/record_wpr_unittest.py
[modify] https://crrev.com/51771a7cad87fdf00c949740c06205e71de8830a/telemetry/telemetry/record_wpr.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e06b824195196e7f0e56ad3e5e017a02da0493ee

commit e06b824195196e7f0e56ad3e5e017a02da0493ee
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 04 10:29:30 2019

Roll src/third_party/catapult ebf0d23ee62e..51771a7cad87 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/ebf0d23ee62e..51771a7cad87


git log ebf0d23ee62e..51771a7cad87 --date=short --no-merges --format='%ad %ae %s'
2019-01-04 perezju@chromium.org [telemetry] Remove TimelineBasedPageTest from record_wpr.py


Created with:
  gclient setdep -r src/third_party/catapult@51771a7cad87

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:851948 
TBR=sullivan@chromium.org

Change-Id: Idb1dee30b43f183728970cdb5b1b6a9cb905b442
Reviewed-on: https://chromium-review.googlesource.com/c/1395729
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619905}
[modify] https://crrev.com/e06b824195196e7f0e56ad3e5e017a02da0493ee/DEPS

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f30dedc6ddca36cf842e672b07bad2ee133427fc

commit f30dedc6ddca36cf842e672b07bad2ee133427fc
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Jan 08 10:07:51 2019

[Telemetry] Remove TimelineBasedPageTest from shared_state

The soon to be deprecated class is already a no-op for all its method
calls, so it can be cleanly removed from shared_state.

Also take the chance to do a bit of cleanup.

Bug:  chromium:851948 
Change-Id: Ie30dde1a462129b989421c715d99287c80733b80
Reviewed-on: https://chromium-review.googlesource.com/c/1394566
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/f30dedc6ddca36cf842e672b07bad2ee133427fc/telemetry/telemetry/testing/fakes/__init__.py
[modify] https://crrev.com/f30dedc6ddca36cf842e672b07bad2ee133427fc/telemetry/telemetry/page/shared_page_state.py

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f60992805b082f3d90e50fc512d1e9bd02d7ff92

commit f60992805b082f3d90e50fc512d1e9bd02d7ff92
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 08 11:56:26 2019

Roll src/third_party/catapult 99f5f50d9f56..f30dedc6ddca (1 commits)

https://chromium.googlesource.com/catapult.git/+log/99f5f50d9f56..f30dedc6ddca


git log 99f5f50d9f56..f30dedc6ddca --date=short --no-merges --format='%ad %ae %s'
2019-01-08 perezju@chromium.org [Telemetry] Remove TimelineBasedPageTest from shared_state


Created with:
  gclient setdep -r src/third_party/catapult@f30dedc6ddca

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:851948 
TBR=sullivan@chromium.org

Change-Id: I33fc52d0f4b18a2df6890818b48483a53b1ce8c7
Reviewed-on: https://chromium-review.googlesource.com/c/1400604
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#620691}
[modify] https://crrev.com/f60992805b082f3d90e50fc512d1e9bd02d7ff92/DEPS

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/4dbf1ef8fd93fd90aa85fb7739736fa25d226187

commit 4dbf1ef8fd93fd90aa85fb7739736fa25d226187
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Jan 08 12:15:09 2019

[telemetry] Remove TimelineBasedPageTest

Class is no longer used by any client.

This CL also moves TBMv2 tests next to TBMv1 in
timeline_based_measurement_unittest.py, and clearly labels them as such.

Bug:  chromium:851948 
Change-Id: Ib3676996b8ef1eff4a43fe7c6453a89db7f037d8
Reviewed-on: https://chromium-review.googlesource.com/c/1396157
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>

[modify] https://crrev.com/4dbf1ef8fd93fd90aa85fb7739736fa25d226187/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
[delete] https://crrev.com/f30dedc6ddca36cf842e672b07bad2ee133427fc/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
[delete] https://crrev.com/f30dedc6ddca36cf842e672b07bad2ee133427fc/telemetry/telemetry/web_perf/timeline_based_page_test.py

Status: Fixed (was: Started)
\o/
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e4a20f88f11bd08a7d405e169133e1081782ee

commit e6e4a20f88f11bd08a7d405e169133e1081782ee
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 08 13:42:57 2019

Roll src/third_party/catapult f30dedc6ddca..4dbf1ef8fd93 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/f30dedc6ddca..4dbf1ef8fd93


git log f30dedc6ddca..4dbf1ef8fd93 --date=short --no-merges --format='%ad %ae %s'
2019-01-08 perezju@chromium.org [telemetry] Remove TimelineBasedPageTest


Created with:
  gclient setdep -r src/third_party/catapult@4dbf1ef8fd93

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:851948 
TBR=sullivan@chromium.org

Change-Id: I45c6ffdfa65ad8b73f3f93ed6eb83994c6a5ce79
Reviewed-on: https://chromium-review.googlesource.com/c/1400609
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#620702}
[modify] https://crrev.com/e6e4a20f88f11bd08a7d405e169133e1081782ee/DEPS

Comment 19 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 20 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment