Issue metadata
Sign in to add a comment
|
App crashes on tapping on Hide for now in recent tabs. |
||||||||||||||||||||
Issue descriptionApp Version: 69.0.3456.0 canary iOS Version: 10.3.3,iOS 11.4 Device: iPad Steps to reproduce: 1.Install and Launch chrome. 2.Sign in to chrome and wait for the devices to sync. 3.Tap on tabswithcer > tap on Other devices icon. 4.Long tap on the arrow on synced devices. 5.Tap on Hide for now Observed results: App crashes Expected results: App should not crash Number of times you were able to reproduce: 3/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Link to Video : https://drive.google.com/file/d/1QhnMFVP0QB82Criwjz2H_oRyV8EJedtD/view?usp=sharing Crash log : https://crash.corp.google.com/browse?stbtiq=d06f6693c0adda28 Stack Trace : Thread 0 (id: 0x403) CRASHED [EXC_SOFTWARE / UNCAUGHT_NS_EXCEPTION @ 0x00000001919bafe0 ] MAGIC SIGNATURE THREAD Stack Quality84%Show frame trust levels 0x00000001919bafe0 (CoreFoundation + 0x0012cfe0 ) __exceptionPreprocess 0x000000019041c534 (libobjc.A.dylib + 0x00008534 ) objc_exception_throw 0x00000001919baeb0 (CoreFoundation + 0x0012ceb0 ) +[NSException raise:format:arguments:] 0x000000019245375c (Foundation + 0x000ae75c ) -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] 0x0000000197cc4610 (UIKit + 0x001ee610 ) -[UITableView _endCellAnimationsWithContext:] 0x000000010094bf2c (Chrome -recent_tabs_table_view_controller.mm:1029 ) -[RecentTabsTableViewController removeSessionAtSessionSectionIdentifier:] 0x000000010094bb0c (Chrome -recent_tabs_table_view_controller.mm:975 ) __49-[RecentTabsTableViewController handleLongPress:]_block_invoke.311 0x000000010034a4b8 (Chrome -alert_coordinator.mm:84 ) __50-[AlertCoordinator addItemWithTitle:action:style:]_block_invoke 0x0000000197f852f0 (UIKit + 0x004af2f0 ) -[UIAlertController _invokeHandlersForAction:] 0x0000000197f85c0c (UIKit + 0x004afc0c ) __85-[UIAlertController _dismissAnimated:triggeringAction:triggeredByPopoverDimmingView:]_block_invoke.454 0x0000000197e33264 (UIKit + 0x0035d264 ) -[UIPresentationController transitionDidFinish:] 0x0000000197e36a54 (UIKit + 0x00360a54 ) __56-[UIPresentationController runTransitionForCurrentState]_block_invoke_2 0x0000000197c0a58c (UIKit + 0x0013458c ) -[_UIViewControllerTransitionContext completeTransition:] 0x0000000197b1e534 (UIKit + 0x00048534 ) -[UIViewAnimationBlockDelegate _didEndBlockAnimation:finished:context:] 0x0000000197b1e05c (UIKit + 0x0004805c ) -[UIViewAnimationState sendDelegateAnimationDidStop:finished:] 0x0000000197b1de78 (UIKit + 0x00047e78 ) -[UIViewAnimationState animationDidStop:finished:] 0x0000000194ccf0d0 (QuartzCore + 0x001130d0 ) CA::Layer::run_animation_callbacks(void*) 0x000000019087299c (libdispatch.dylib + 0x0000199c ) _dispatch_client_callout 0x00000001908775e4 (libdispatch.dylib + 0x000065e4 ) _dispatch_main_queue_callback_4CF 0x00000001919690c4 (CoreFoundation + 0x000db0c4 ) __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ 0x0000000191966ce0 (CoreFoundation + 0x000d8ce0 ) __CFRunLoopRun 0x0000000191896da0 (CoreFoundation + 0x00008da0 ) CFRunLoopRunSpecific 0x0000000193301070 (GraphicsServices + 0x0000c070 ) GSEventRunModal 0x0000000197b4ac98 (UIKit + 0x00074c98 ) UIApplicationMain 0x00000001000dca90 (Chrome -chrome_exe_main.mm:54 ) main
,
Jun 13 2018
,
Jun 15 2018
I'm not able to reproduce this on TOT. I suspect this has been fixed. Marking as fixed. Feel free to reopen if testing shows this is still a problem.
,
Jun 15 2018
Just wanted to note that I tested on an iPad device with iOS 11.0.
,
Jun 15 2018
Issue can be reproduced test on the build 69.0.3461.0 canary tested on device iPad Mini 2(10.3.3), works fine in iPad Mini iOS 11 Video : https://drive.google.com/file/d/1ba3CkCD0_aCknGW0nhw9ro1N7P3QlCxb/view?usp=sharing
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20
,
Jun 20 2018
,
Jun 20 2018
,
Jun 20 2018
CL in-flight. Thanks for finding this obscure bug.
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3423776a6443794d46538ffe38f55efbede00d31 commit 3423776a6443794d46538ffe38f55efbede00d31 Author: edchin <edchin@chromium.org> Date: Thu Jun 21 07:00:30 2018 [ios] Fix recent tabs crash in iOS 10 Previously, model changes and table updates were not synchronized for handling "Hide for now" on long presses in recent tabs. This CL moves the model changes into the same block as table updates so that they are fed together into |-performBatchUpdates:| in iOS 11 and |-beginUpdates| in iOS 10. This was only crashing in iOS 10 iPad, but theoretically, it is wrong and would crash in other configurations. Bug: 851946 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4fe35eb06cf77d1fb6097a5508d72dd1e93fc6ee Reviewed-on: https://chromium-review.googlesource.com/1108346 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569175} [modify] https://crrev.com/3423776a6443794d46538ffe38f55efbede00d31/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
,
Jun 21 2018
,
Aug 14
This issue is still reproducible in: App Version: 70.0.3521.0 canary Devices: iPhone 7 Plus, iPhone 7 iOS Version: 10.3.3 only App is still crashing tapping on 'Hide for now' from recent tabs. Crash Log: https://crash.corp.google.com/browse?stbtiq=96426ac78e501a62 Video: https://drive.google.com/open?id=14ofCMCQ1_yWohe7H0hSzx-2u6MmcpuRc
,
Aug 21
Hey Ed, do you think this should this block M69?
,
Nov 1
Here's the crash magic signature. https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_iOS%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27-%5BRecentTabsTableViewController+removeSessionAtSessionSectionIdentifier%3A%5D%27&stbtiq=&reportid=&index=0 sczs@, are you the best person to resolve this since it is recent tabs? |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by marq@chromium.org
, Jun 13 2018Labels: Q2
Owner: edchin@chromium.org
Status: Assigned (was: Untriaged)