New issue
Advanced search Search tips

Issue 851942 link

Starred by 1 user
Status: Fixed
Owner:
mek@chromium.org
Closed: Jun 2018
Cc:
jsb...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

virtual/mojo-blob-urls/external/wpt/FileAPI/url/cross-global-revoke.sub.html is flaky

Project Member Reported by pdr@chromium.org, Jun 12 2018 
This test is flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2FFileAPI%2Furl%2Fcross-global-revoke.sub.html

It has made my CQ run sad:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/115215

Expected:
PASS It is possible to revoke same-origin blob URLs from a different worker global.

Actual:
FAIL It is possible to revoke same-origin blob URLs from a different worker global. assert_unreached: Should have rejected: undefined Reached unreachable code



Mek, can you take a look? This may be part of the larger https://crbug.com/800986 but we should disable these tests or mark them as flaky until the underlying issue is fixed.

Comment 1 by mek@chromium.org, Jun 12 2018

Summary: virtual/mojo-blob-urls/external/wpt/FileAPI/url/cross-global-revoke.sub.html is flaky (was: wpt/FileAPI/url/cross-global-revoke.sub.html is flaky)
To be clear it's only the virtual/mojo-blob-urls version of this test that is flaky (the regular version just non-flakily fails all the time). I'll slightly rework the test to no longer be flaky (the problem is that different threads necesarily use different mojo pipes to talk to the blob URL system and thus it is possible for the message from the worker to the main page that the URL was revoked to arrive before the actual URL revocation has arrived in the browser process).
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a885cb4987d3af87314b5c6bb13caf98a1bd2fc3

commit a885cb4987d3af87314b5c6bb13caf98a1bd2fc3
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Jun 12 16:45:19 2018

Fix test flakiness around multi-threaded blob URL revocation.

Registering a new blob URL in the worker will ensure (at least in chrome)
that the revocation has been fully processed before the main thread
tries to fetch the now revoked URL.

Bug:  851942 
Change-Id: I12e794682dbb5b34dc08fe2a7d398e3ba02aaffa
Reviewed-on: https://chromium-review.googlesource.com/1097230
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566460}
[modify] https://crrev.com/a885cb4987d3af87314b5c6bb13caf98a1bd2fc3/third_party/WebKit/LayoutTests/external/wpt/FileAPI/url/resources/revoke-helper.js

Comment 3 by mek@chromium.org, Jun 12 2018

Status: Fixed (was: Assigned)

Comment 4 by benhenry@chromium.org, Jun 15 2018

Components: Blink>Storage>FileAPI

Comment 5 by benhenry@chromium.org, Jun 15 2018

Components: -Blink>FileAPI
►

Sign in to add a comment